From: Nicolas Frey <n.frey@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH pve-common] cli: fix #6762: only copy properties if defined
Date: Tue, 7 Oct 2025 17:18:38 +0200 [thread overview]
Message-ID: <039680bc-8068-43a3-ab17-9502b4a5a236@proxmox.com> (raw)
In-Reply-To: <20251007135638.136536-1-n.frey@proxmox.com>
Superseded-by: https://lore.proxmox.com/pve-devel/20251007151649.163255-1-n.frey@proxmox.com/T/#u
On 10/7/25 3:56 PM, Nicolas Frey wrote:
> Adds a defined check to the copy, as to not result in the bugfixes
> reported error when double tabbing on `pveceph status`.
>
> Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=6762
> Signed-off-by: Nicolas Frey <n.frey@proxmox.com>
> ---
> src/PVE/CLIHandler.pm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/PVE/CLIHandler.pm b/src/PVE/CLIHandler.pm
> index 89cb7b7..cdd71c7 100644
> --- a/src/PVE/CLIHandler.pm
> +++ b/src/PVE/CLIHandler.pm
> @@ -455,7 +455,8 @@ my $print_bash_completion = sub {
>
> my $info = $class->map_method_by_name($name);
>
> - my $prop = { %{ $info->{parameters}->{properties} } }; # copy
> + my $prop = { %{ $info->{parameters}->{properties} } }
> + if defined $info->{parameters}->{properties}; # copy
> $prop = { %$prop, %$formatter_properties } if $formatter_properties;
>
> my $print_parameter_completion = sub {
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-10-07 15:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-07 13:56 Nicolas Frey
2025-10-07 14:47 ` Thomas Lamprecht
2025-10-07 15:13 ` Nicolas Frey
2025-10-07 15:18 ` Nicolas Frey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039680bc-8068-43a3-ab17-9502b4a5a236@proxmox.com \
--to=n.frey@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox