From: Matthias Heiserer <m.heiserer@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH widget-toolkit V2] ComboGrid: fix sorting when filtering
Date: Thu, 28 Apr 2022 11:57:06 +0200 [thread overview]
Message-ID: <028e1f50-21f9-c3c2-b9f7-d288672d4582@proxmox.com> (raw)
In-Reply-To: <6b2df114-d719-4b6e-4668-9768c642d1ad@proxmox.com>
On 27.04.2022 12:01, Thomas Lamprecht wrote:
> nit, ant I don't want to be annoying, but can you please add a empty line
> below, and maybe even above the series-change log for easier visibility?
> I'd at least appreciate that quite a bit, thx!
>
Sure!
>> src/form/ComboGrid.js | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>>
>> diff --git a/src/form/ComboGrid.js b/src/form/ComboGrid.js
>> index 33c1d75..fa1078d 100644
>> --- a/src/form/ComboGrid.js
>> +++ b/src/form/ComboGrid.js
>> @@ -12,6 +12,9 @@ Ext.define('Proxmox.form.ComboGrid', {
>>
>> // this value is used as default value after load()
>> preferredValue: undefined,
>> + clearFilterOnBlur: false,
>
> this changes the default of an ExtJS config that is used in other context though?
>
I think the idea was that the current behaviour (clearing filter when
sorting) is undesirable in all grids and as default, but can be
overridden. Meanwhile, the collapse listener covers the cases where
clearing the filter is desired and already happens.
Depending on which you prefer, I'll send in a v2 with a/this short
explanation included, otherwise I guess the best thing would be a custom
child class for this functionality and use that in all the places where
it definitely makes sense?
prev parent reply other threads:[~2022-04-28 9:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-16 11:34 Matthias Heiserer
2022-04-27 10:01 ` Thomas Lamprecht
2022-04-28 9:57 ` Matthias Heiserer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=028e1f50-21f9-c3c2-b9f7-d288672d4582@proxmox.com \
--to=m.heiserer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox