public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Filip Schauer <f.schauer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH guest-common/qemu-server/docs/manager v1 0/11] Virtiofs improvements
Date: Wed, 29 Oct 2025 14:39:16 +0100	[thread overview]
Message-ID: <0289a744-370f-4671-af04-adb08f2f4868@proxmox.com> (raw)
In-Reply-To: <20251020121807.280441-1-m.frank@proxmox.com>

On 20/10/2025 14:18, Markus Frank wrote:
> This patch series superseeds the patch series
> "virtiofs: add thread-pool-size and improve docs" and adds support for
> the read-only flag and live-migration.
>
> Virtiofsd migration documentation:
> https://gitlab.com/virtio-fs/virtiofsd/-/blob/main/doc/migration.md
>
> build-order:
> 1. pve-guest-common
> 2. qemu-server
> 3. pve-docs
> 4. pve-manager

Tested read-only: Works as expected.

Tested live migration with both find-paths and file-handles while
reading a small file:
1. Opened file on first node
2. Read a few bytes from the open file handle
3. Migrated the VM to the second node
4. Read some more bytes from the open file handle
This worked fine.

Tested live migration while copying a 1GiB file within the virtiofs:
1. Mounted a CIFS share on all nodes and configured the directory
    mappings with `file-handles` as the live migration method
2. Created a 1GiB file: `dd if=/dev/urandom of=testA bs=4M count=256`
3. Started a copy inside the VM:
    `/mnt/virtiofs# dd if=testA of=testB status=progress`
4. Started a live migration
5. Immediately after migration dd failed with:
    ```
    dd: error reading 'testA': Input/output error
    dd: closing input file 'testA': Input/output error
    ```
    I tried the same with Live Migration Method set to `find-paths`.
    This also failed upon migration. This time with:
    ```
    dd: writing to 'testB': Input/output error
    dd: closing input file 'testA': Input/output error
    ```

Another thing I noticed: The pveDirMapSelector in the VirtiofsInputPanel
does not show whether a directory mapping is configured for the node.
Meanwhile the pvePCIMapSelector and pveUSBMapSelector show either
"No mapping for node..." or "Mapping matches host data". Might be nice
to have that for Virtiofs too.

PS: Please run `make tidy`



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

      parent reply	other threads:[~2025-10-29 13:38 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-20 12:17 Markus Frank
2025-10-20 12:17 ` [pve-devel] [PATCH guest-common v1 1/11] mapping: dir: add 'live-migration-method' parameter Markus Frank
2025-10-20 12:17 ` [pve-devel] [PATCH qemu-server v1 2/11] fix #6370: virtiofs: add support for thread-pool-size option Markus Frank
2025-10-20 12:17 ` [pve-devel] [PATCH qemu-server v1 3/11] virtiofs: add readonly option Markus Frank
2025-10-20 12:17 ` [pve-devel] [PATCH qemu-server v1 4/11] virtiofs: add live migration support Markus Frank
2025-10-20 12:17 ` [pve-devel] [PATCH docs v1 5/11] virtiofs: add explanation for cache=metadata behavior Markus Frank
2025-10-20 12:17 ` [pve-devel] [PATCH docs v1 6/11] virtiofs: add table for optional parameters Markus Frank
2025-10-20 12:17 ` [pve-devel] [PATCH docs v1 7/11] virtiofs: add thread-pool-size description Markus Frank
2025-10-20 12:17 ` [pve-devel] [PATCH docs v1 8/11] virtiofs: add documentation for live migration Markus Frank
2025-10-20 12:17 ` [pve-devel] [PATCH manager v1 09/11] fix #6370: ui: virtiofs edit: add support for thread-pool-size option Markus Frank
2025-10-20 12:17 ` [pve-devel] [PATCH manager v1 10/11] virtiofs edit: add readonly checkbox Markus Frank
2025-10-20 12:17 ` [pve-devel] [PATCH manager v1 11/11] directory mapping: add live-migration-method option for virtiofs Markus Frank
2025-10-29 13:39 ` Filip Schauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0289a744-370f-4671-af04-adb08f2f4868@proxmox.com \
    --to=f.schauer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal