From: Dominik Csapak <d.csapak@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Filip Schauer <f.schauer@proxmox.com>
Subject: Re: [pve-devel] [PATCH v3 container 1/1] Add device passthrough
Date: Wed, 8 Nov 2023 12:03:05 +0100 [thread overview]
Message-ID: <022edc86-4802-4b7e-909f-6695dcb87cd8@proxmox.com> (raw)
In-Reply-To: <20231107134642.110576-3-f.schauer@proxmox.com>
did not properly review this, but what caught my attention was that you
don't define any permissions for this new property?
by default new options in pve-container only need 'VM.Config.Options' but
IMHO this should be root only for now? (unless we can use mappings
where we can use those permissions)
next prev parent reply other threads:[~2023-11-08 11:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-07 13:46 [pve-devel] [PATCH v3 many] Add container " Filip Schauer
2023-11-07 13:46 ` [pve-devel] [PATCH v3 common 1/1] tools: Add mknod syscall Filip Schauer
2023-11-07 13:46 ` [pve-devel] [PATCH v3 container 1/1] Add device passthrough Filip Schauer
2023-11-08 11:03 ` Dominik Csapak [this message]
2023-11-10 10:44 ` Wolfgang Bumiller
2023-11-13 10:33 ` Filip Schauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=022edc86-4802-4b7e-909f-6695dcb87cd8@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=f.schauer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox