public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Aaron Lauterer <a.lauterer@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager] ui: osd: warn if removal could be problematic
Date: Fri, 4 Feb 2022 17:42:39 +0100	[thread overview]
Message-ID: <01f8c7af-dbf2-befe-450b-9ad5739c87fe@proxmox.com> (raw)
In-Reply-To: <20220204095006.127477-1-a.lauterer@proxmox.com>

On 04.02.22 10:50, Aaron Lauterer wrote:
> If an OSD is removed during the wrong conditions, it could lead to
> blocked IO or worst case data loss.
> 
> Check against global flags that limit the capabilities of Ceph to heal
> itself (norebalance, norecover, noout) and if there are degraded
> objects.
> 
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
> 
> Those are the things to check for that came to mind. If someone thinks
> that we should definitely check for more, I am happy to send a v2.
> 
> I am also open to suggestions on how to phrase the warnings better.
> 
> I opted for separate hints to be able to show detailed hints so the
> users have an idea how to act on the warning and to keep the logic
> behind them simple.

independent of what we then check, this should actually but a load mask on the dialogue
or the like, as else it may be to late if backend is slow and/or network latency between
UI and PVE is high (E.g., the coverage @ deutsches eck gives me about 10 to 15s spikes
when travelling through via train, not that I expect to delete OSDs from there in
production critical setups anytime soon ;)




      reply	other threads:[~2022-02-04 16:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-04  9:50 Aaron Lauterer
2022-02-04 16:42 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=01f8c7af-dbf2-befe-450b-9ad5739c87fe@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=a.lauterer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal