[pve-devel] Some translation strings missing

[pve-devel] Some translation strings missing

[Daniel Koć]

Hi!

I just finished full Polish translation, but found that some strings
can't be translated. I made a quick search and it looks like some of
them are not yet gettextized:

$ grep -r -e "fieldLabel: '" -e "text: '" * | grep -v gettext | grep -v
"do not localize" | wc -l
228

(It includes PBS and PMG messages, since all the translation messages
are merged into one file eventually.)

Is it possible to make a patch which fixes it?

This list is not complete, there are some other missing messages like:

  * tooltip for documentation link for PVE and PMG (PBS does not have
    this tip)
  * "Subscription" section title on PBS dashboard
  * Ceph installation wizard text

It would be great to make them also translatable.

-- 
"Holy mother forking shirt balls!" [E. Shellstrop]

Re: [pve-devel] Some translation strings missing

[Thomas Lamprecht]

Hi!

On 04.05.21 07:57, Daniel Koć wrote:
> I just finished full Polish translation, but found that some strings
> can't be translated. I made a quick search and it looks like some of
> them are not yet gettextized:
> 
> $ grep -r -e "fieldLabel: '" -e "text: '" * | grep -v gettext | grep -v
> "do not localize" | wc -l
> 228

Some of those are things like "OSD" or "Ceph" which cannot be translated, 

some are where one probably could argue for and some are def. just missed.

> 
> (It includes PBS and PMG messages, since all the translation messages
> are merged into one file eventually.)
> 
> Is it possible to make a patch which fixes it?

Do you want to take a shot at this and send a patch? It shouldn't be too hard,
relatively speaking.

https://pve.proxmox.com/wiki/Developer_Documentation#Working_on_the_code

> 
> This list is not complete, there are some other missing messages like:
> 
>   * tooltip for documentation link for PVE and PMG (PBS does not have
>     this tip)
>   * "Subscription" section title on PBS dashboard
>   * Ceph installation wizard text

The latter was not made a gettext as it's a long text, really different
from the other classic field or button label texts. It changed a few times
already, and it's way harder to review for correctness. Further, we
currently cannot detect gettext instances spanning over multiple lines, so
the parser would need adaption.
That's not saying I'd reject making it a gettext in general, just stating
the reasoning for initially not doing so.

> 
> It would be great to make them also translatable.
> 

cheers,
Thomas

Re: [pve-devel] Some translation strings missing

[Daniel Koć]

W dniu 04.05.2021 o 09:12, Thomas Lamprecht pisze:
> Some of those are things like "OSD" or "Ceph" which cannot be translated, 


I don't see there is a strong dividing line. The only ones that really
should not be translated are those which would create technical
problems. Other than that there could be for example transliterations
(like "Цэпх" or "Цэф" for Ceph in cyryllic - just like McDonald's in
Russia or Bulgaria), aliases ("IP 4" instead of "IPv4") or maybe long
versions etc. One never knows.

On the other hand there are also some rare unneeded ones, like:

#: pve-manager/www/manager6/storage/Base.js:65
msgid "1"
msgstr ""

#: pve-manager/www/manager6/data/ResourceStore.js:186
msgid "maxcpu"
msgstr ""


> Do you want to take a shot at this and send a patch? It shouldn't be
> too hard,
> relatively speaking.

Yes, I will try that so we can move forward.

It would also help me send translation changes so they can be easily
applied.


> The latter was not made a gettext as it's a long text, really different
> from the other classic field or button label texts. It changed a few times
> already, and it's way harder to review for correctness. Further, we
> currently cannot detect gettext instances spanning over multiple lines, so
> the parser would need adaption.
> That's not saying I'd reject making it a gettext in general, just stating
> the reasoning for initially not doing so.

Sure, I understand that. Just some thoughts:

At some point it would be good to let translators catch up with the
latest changes before the release. I see no problem with rearranging
text like this, but it can be "freezed" for translation in RC phase and
"unfrozen" after the release. I was translating some rare big chunks of
gettext before, so it exists in the real world.


-- 
"Holy mother forking shirt balls!" [E. Shellstrop]