From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com, Stefan Reiter <s.reiter@proxmox.com>
Subject: Re: [pve-devel] [PATCH 0/7] Work around QEMU 5.2 windows incompatibility
Date: Fri, 5 Mar 2021 08:24:14 +0100 [thread overview]
Message-ID: <01cf3904-1fa6-983b-e8f8-d4aae50b93a5@proxmox.com> (raw)
In-Reply-To: <20210304125209.24078-1-s.reiter@proxmox.com>
Didn't follow this issue too closely, but what about restoring a
pre-QEMU-ACPI-patch Windows VM backup in a post-QEMU-ACPI-patch world?
Those would need to get pinned as well, right? Doing the pinning itself
on restore shouldn't be difficult, but a good way to detect when it's
needed is needed.
Am 04.03.21 um 13:52 schrieb Stefan Reiter:
> ...and make machine version configurable in the GUI, to allow users to return to
> the default behaviour of always using the latest one.
>
> The workaround is based on a postinst script running when upgrading the
> qemu-server package, which sets the machine version of all effected Windows VMs
> to pc-(i440fx|q35)-5.1 to pin them to the last version still using the old ACPI
> table layout.
>
> Note: the postinst patch requires Fabian's #3301 series:
> https://lists.proxmox.com/pipermail/pve-devel/2021-March/047175.html
>
>
> pve-qemu: Stefan Reiter (2):
> add static supported machines file
> add ACPI compat patch for 5.1 and older machine types
>
> debian/parse-machines.pl | 21 ++++
> ...restore-device-paths-for-pre-5.1-vms.patch | 108 ++++++++++++++++++
> debian/patches/series | 1 +
> debian/rules | 4 +-
> 4 files changed, 133 insertions(+), 1 deletion(-)
> create mode 100755 debian/parse-machines.pl
> create mode 100644 debian/patches/extra/0009-i386-acpi-restore-device-paths-for-pre-5.1-vms.patch
>
> qemu-server: Stefan Reiter (2):
> api: add Machine module to query machine types
> add postinst with Windows device incompatibility workaround
>
> PVE/API2/Qemu/Machine.pm | 49 +++++++++++++++++++++
> PVE/API2/Qemu/Makefile | 2 +-
> debian/postinst | 95 ++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 145 insertions(+), 1 deletion(-)
> create mode 100644 PVE/API2/Qemu/Machine.pm
> create mode 100755 debian/postinst
>
> manager: Stefan Reiter (3):
> api: register Qemu::Machine call
> ui: create MachineEdit window
> ui: MachineEdit: add option for machine version pinning
>
> PVE/API2/Nodes.pm | 6 ++
> www/manager6/Makefile | 1 +
> www/manager6/qemu/HardwareView.js | 16 +----
> www/manager6/qemu/MachineEdit.js | 107 ++++++++++++++++++++++++++++++
> 4 files changed, 115 insertions(+), 15 deletions(-)
> create mode 100644 www/manager6/qemu/MachineEdit.js
>
prev parent reply other threads:[~2021-03-05 7:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-04 12:52 Stefan Reiter
2021-03-04 12:52 ` [pve-devel] [PATCH pve-qemu 1/7] add static supported machines file Stefan Reiter
2021-03-05 21:27 ` [pve-devel] applied: " Thomas Lamprecht
2021-03-04 12:52 ` [pve-devel] [PATCH pve-qemu 2/7] add ACPI compat patch for 5.1 and older machine types Stefan Reiter
2021-03-05 21:27 ` [pve-devel] applied: " Thomas Lamprecht
2021-03-04 12:52 ` [pve-devel] [PATCH qemu-server 3/7] api: add Machine module to query " Stefan Reiter
2021-03-05 21:28 ` [pve-devel] applied: " Thomas Lamprecht
2021-03-04 12:52 ` [pve-devel] [PATCH qemu-server 4/7] add postinst with Windows device incompatibility workaround Stefan Reiter
2021-03-04 13:31 ` Stefan Reiter
2021-03-05 8:03 ` Fabian Ebner
2021-03-05 21:32 ` [pve-devel] NAK: " Thomas Lamprecht
2021-03-04 12:52 ` [pve-devel] [PATCH manager 5/7] api: register Qemu::Machine call Stefan Reiter
2021-03-05 21:33 ` [pve-devel] applied: " Thomas Lamprecht
2021-03-04 12:52 ` [pve-devel] [PATCH manager 6/7] ui: create MachineEdit window Stefan Reiter
2021-03-05 21:33 ` [pve-devel] applied: " Thomas Lamprecht
2021-03-04 12:52 ` [pve-devel] [PATCH manager 7/7] ui: MachineEdit: add option for machine version pinning Stefan Reiter
2021-03-05 21:36 ` [pve-devel] applied: " Thomas Lamprecht
2021-03-05 7:24 ` Fabian Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01cf3904-1fa6-983b-e8f8-d4aae50b93a5@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.reiter@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox