From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stoiko Ivanov <s.ivanov@proxmox.com>
Subject: [pve-devel] applied: [PATCH kernel-helper] add dedicated removable installation
Date: Tue, 21 Nov 2023 21:25:05 +0100 [thread overview]
Message-ID: <01b3ec54-b474-4d3a-a723-2cd07b4c3aff@proxmox.com> (raw)
In-Reply-To: <20231121201902.1893738-1-s.ivanov@proxmox.com>
Am 21/11/2023 um 21:19 schrieb Stoiko Ivanov:
> seems adding `--removable` makes grub install ignore most other
> information - e.g. the bootloader-id (guessed based on [0]).
> add dedicated call with out `--removable` in addition
>
> Seems that's the reason why our installer also 'rolls its own
> removable' [1]
>
> minimally tested with an ISO with this installed and an install with
> ZFS on / (RAID1).
>
> [0] https://git.savannah.gnu.org/cgit/grub.git/tree/util/grub-install.c#n1142
> [1] https://git.proxmox.com/?p=pve-installer.git;a=blob;f=Proxmox/Install.pm;h=8825699416475b1934527531db4fbb40e9473ce8;hb=HEAD#l608
>
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> src/bin/proxmox-boot-tool | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
>
applied, surely one cannot have enough grubs installed, thanks!
prev parent reply other threads:[~2023-11-21 20:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 20:19 [pve-devel] " Stoiko Ivanov
2023-11-21 20:25 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01b3ec54-b474-4d3a-a723-2cd07b4c3aff@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox