From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fiona Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH edk2-firmware] add patch to revert addition of EFI memory attributes protocol for x86_64
Date: Thu, 27 Mar 2025 17:39:04 +0100 [thread overview]
Message-ID: <01aa9a50-0d7e-45e0-b64c-19f0c7658103@proxmox.com> (raw)
In-Reply-To: <20250327115309.136068-1-f.ebner@proxmox.com>
Am 27.03.25 um 12:53 schrieb Fiona Ebner:
> Because of a long-standing bug in shim [0], booting will fail for
> distibutions that do not include the fix yet, like Rocky Linux 9.5
> and other CentOS-based distibutions. This is cased by the addition
> of the EFI_MEMORY_ATTRIBUTE_PROTOCOL in edk2 commit efaa102d00
> ("UefiCpuPkg: Produce EFI memory attributes protocol") for x86_64.
>
> Even with the fix in shim, issues in commonly shipped versions of GRUB
> remain [1].
>
> This is relatively recent, i.e. in the edk2-stable202502 tag, and
> since current non-minor distributions are still affected, revert the
> problematic commit for now.
>
> Once issues are less common in distributions, an option to support
> disabling it (via fw_cfg on the QEMU command line) can still be added
> [1]. Then, it can also be nicely documented as a known issue while
> giving users guidance.
>
> There already is a similar patch for ARM [2] inherited from the Debian
> upstream version.
>
> The problematic commit is EFI_MEMORY_ATTRIBUTE_PROTOCOL was added for x86_64 recently in the
> edk2-stable202502 tag. Since current non-minor distributions are still
> affected, a revert is done for now.
>
> [0]: https://github.com/rhboot/shim/commit/c7b305152802c8db688605654f75e1195def9fd6
> [1]: https://github.com/tianocore/edk2/pull/10667
> [2]: ./debian/patches/ArmVirtPkg-disable-the-EFI_MEMORY_ATTRIBUTE-protocol.patch
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> ...g-Produce-EFI-memory-attributes-prot.patch | 368 ++++++++++++++++++
> debian/patches/series | 1 +
> 2 files changed, 369 insertions(+)
> create mode 100644 debian/patches/Revert-UefiCpuPkg-Produce-EFI-memory-attributes-prot.patch
>
>
applied, re-exported the revert using git format-patch as the unusual
DOS line-endings that EDK2 source code uses seem to got lost somewhere
along the way, and while I could have used quilt I figured there's no
harm with format-patch, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-03-27 16:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-27 11:53 [pve-devel] " Fiona Ebner
2025-03-27 16:39 ` Thomas Lamprecht [this message]
2025-03-28 8:55 ` [pve-devel] applied: " Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01aa9a50-0d7e-45e0-b64c-19f0c7658103@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal