public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Aaron Lauterer <a.lauterer@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
	Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH futter_frontend 1/2] fix android splash screen logo
Date: Tue, 21 Dec 2021 10:25:16 +0100	[thread overview]
Message-ID: <01a3aed3-6d60-a768-4543-4d235130f6da@proxmox.com> (raw)
In-Reply-To: <accbfa58-f897-a9cd-082f-d263473d4dcf@proxmox.com>



On 12/20/21 20:21, Thomas Lamprecht wrote:
> On 20/12/2021 16:38, Aaron Lauterer wrote:
>> The new splash screen that came with Android 12 has stricter rules
>> regarding the size and form of the logo in the splash screen [0].
>>
>> We do need to have a drawable that is a square with the logo / icon in
>> the center. That means the current approach with the png image resulted
>> in it being scaled to the full width and the circular mask cut if off.
>> The result was a broken looking splash screen.
>>
>> I opted for the stacked variant of the logo and saved it as a vector
>> drawable in the xml format that android wants.
> 
> I'd like to have the original svg too, ideally with some (Android SDK) CLI
> tool to convert it, or at least the steps described required for that.
> 
> Please also just replace the content of the launch_background.xml drawable.

Will do. If I don't find a CLI way to convert it, I'll document the steps.

> 
>>
>> [0] https://developer.android.com/guide/topics/ui/splash-screen
>>
>> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
>> ---
>>   .../main/res/drawable/proxmox_splash_logo.xml | 69 +++++++++++++++++++
>>   .../app/src/main/res/values-night/styles.xml  |  2 +-
>>   android/app/src/main/res/values/styles.xml    |  2 +-
>>   3 files changed, 71 insertions(+), 2 deletions(-)
>>   create mode 100644 android/app/src/main/res/drawable/proxmox_splash_logo.xml
>>
> 
> 
> 




  reply	other threads:[~2021-12-21  9:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-20 15:38 Aaron Lauterer
2021-12-20 15:38 ` [pve-devel] [PATCH flutter_frontend 2/2] remove unused drawables for android splash screen Aaron Lauterer
2021-12-20 19:25   ` Thomas Lamprecht
2021-12-20 19:21 ` [pve-devel] [PATCH futter_frontend 1/2] fix android splash screen logo Thomas Lamprecht
2021-12-21  9:25   ` Aaron Lauterer [this message]
2021-12-20 19:37 ` Thomas Lamprecht
2021-12-21  9:27   ` Aaron Lauterer
2021-12-21  9:36     ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=01a3aed3-6d60-a768-4543-4d235130f6da@proxmox.com \
    --to=a.lauterer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal