From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Matthias Heiserer <m.heiserer@proxmox.com>
Subject: Re: [pve-devel] [PATCH v4 qemu-server 1/2] bump pve-common
Date: Sat, 28 May 2022 09:09:21 +0200 [thread overview]
Message-ID: <012357f5-13ae-e388-2962-109390dabe29@proxmox.com> (raw)
In-Reply-To: <20220527114810.510501-2-m.heiserer@proxmox.com>
This isn't bumping the version of pve-common, but the build-dependency
only (why not the installation dependency too?).
The common commit subject style used for such things, as can be seen by
checking git log on debian/control, is:
"d/control: bump build-dependency of pve-common"
Then a short sentence in the message:
"we require the new <feature/behavior> for XYZ"
On 27/05/2022 13:48, Matthias Heiserer wrote:
> Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
> ---
>
> Changes from v3:
> None
>
> Changes from v1/v2:
> new patch
>
>
> debian/control | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/debian/control b/debian/control
> index af258db..2898593 100644
> --- a/debian/control
> +++ b/debian/control
> @@ -7,7 +7,7 @@ Build-Depends: debhelper (>= 12~),
> libio-multiplex-perl,
> libjson-c-dev,
> libpve-cluster-perl,
> - libpve-common-perl (>= 7.1-3),
> + libpve-common-perl (>= 7.1-4),
> libpve-guest-common-perl (>= 4.1-1),
> libpve-storage-perl (>= 6.1-7),
> libtest-mockmodule-perl,
next prev parent reply other threads:[~2022-05-28 7:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-27 11:48 [pve-devel] [PATCH v4 manager 1/3] fix typo Matthias Heiserer
2022-05-27 11:48 ` [pve-devel] [PATCH v4 qemu-server 1/2] bump pve-common Matthias Heiserer
2022-05-28 7:09 ` Thomas Lamprecht [this message]
2022-05-27 11:48 ` [pve-devel] [PATCH v4 manager] HDEdit: check iothread by default and move it from advanced section Matthias Heiserer
2022-06-10 9:20 ` Fabian Ebner
2022-06-13 9:59 ` Matthias Heiserer
2022-05-27 11:48 ` [pve-devel] [PATCH v4 qemu-server 2/2] fix #3890: warn in GUI for unlikely iothread config Matthias Heiserer
2022-06-10 9:20 ` Fabian Ebner
2022-05-27 11:48 ` [pve-devel] [PATCH v4 manager 3/3] OS defaults: use SCSI single as default controller Matthias Heiserer
2022-06-10 9:20 ` Fabian Ebner
2022-05-28 7:19 ` [pve-devel] applied: [PATCH v4 manager 1/3] fix typo Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=012357f5-13ae-e388-2962-109390dabe29@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=m.heiserer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox