From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Lukas Wagner <l.wagner@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH v4 manager 0/4] vzdump: add 'notification-mode' parameter
Date: Tue, 21 Nov 2023 17:33:49 +0100 [thread overview]
Message-ID: <00dba86a-255d-4adf-89f0-c10008985c19@proxmox.com> (raw)
In-Reply-To: <20231121125240.158044-1-l.wagner@proxmox.com>
Am 21/11/2023 um 13:52 schrieb Lukas Wagner:
> This patch series adds the 'notification-mode' setting for backup jobs.
> It allows users to choose between the 'old-style' notifications
> (mail to configured address, directly via a call to sendmail) or
> the 'new-style' notification system.
>
> notification-mode has three possible values:
> - legacy-sendmail: Use old system, considering mailto/mailtnotification parameters
> - notification-system: Use the new system (always sending a notification, irregardless
> of success/failure. The user is supposed to configure filtering/matching in
> notification settings)
> - auto: use old system if mailto is set, or new system if not
>
> This should provide a fix/workaround for the users' reports of
> - double notifications (these happened in case mailto was set to the same address
> as root@pam)
> - notifications always being sent, even if 'mailnotification' is set to failure
>
> Changes v2 -> v3:
> - change field text in the GUI for the 'mailnotification' param
> This should highlight that this setting only affects the 'legacy-sendmail'
> notification mails
>
> Changes v3 -> v4:
> - fix eslint warnings (thx @Philipp)
> - drop already applied pve-guest-common patch
>
>
>
> pve-manager:
>
> Lukas Wagner (4):
> vzdump: support 'notification-mode' parameter
> ui: backup jobs: add 'notification-mode' selector for backup jobs
> ui: backup: add 'notification-mode' param for one-shot backup jobs.
> ui: backup job: change field text for 'mailnotification' field
>
> PVE/VZDump.pm | 95 +++++++++++--------
> www/manager6/dc/Backup.js | 34 ++++++-
> .../form/NotificationPolicySelector.js | 2 +-
> www/manager6/window/Backup.js | 25 +++++
> 4 files changed, 116 insertions(+), 40 deletions(-)
>
>
> Summary over all repositories:
> 4 files changed, 116 insertions(+), 40 deletions(-)
>
applied, thanks!
prev parent reply other threads:[~2023-11-21 16:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 12:52 [pve-devel] " Lukas Wagner
2023-11-21 12:52 ` [pve-devel] [PATCH v4 pve-manager 1/4] vzdump: support " Lukas Wagner
2023-11-21 12:52 ` [pve-devel] [PATCH v4 pve-manager 2/4] ui: backup jobs: add 'notification-mode' selector for backup jobs Lukas Wagner
2023-11-21 12:52 ` [pve-devel] [PATCH v4 pve-manager 3/4] ui: backup: add 'notification-mode' param for one-shot " Lukas Wagner
2023-11-21 12:52 ` [pve-devel] [PATCH v4 pve-manager 4/4] ui: backup job: change field text for 'mailnotification' field Lukas Wagner
2023-11-21 13:28 ` [pve-devel] [PATCH v4 manager 0/4] vzdump: add 'notification-mode' parameter Philipp Hufnagl
2023-11-21 16:33 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00dba86a-255d-4adf-89f0-c10008985c19@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox