public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH manager] ui: remove experimental from change detection modes description
@ 2024-11-11 11:55 Christian Ebner
  2024-11-11 11:55 ` [pve-devel] [PATCH docs] docs: drop experimental warning for change detection modes Christian Ebner
  2024-11-17 17:36 ` [pve-devel] applied: [PATCH manager] ui: remove experimental from change detection modes description Thomas Lamprecht
  0 siblings, 2 replies; 3+ messages in thread
From: Christian Ebner @ 2024-11-11 11:55 UTC (permalink / raw)
  To: pve-devel

As no issues with the change detection mode set to `metadata` or
`data` have been reported during the prolonged test period, drop the
`experimental` warnings from the description.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 www/manager6/panel/BackupAdvancedOptions.js | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/www/manager6/panel/BackupAdvancedOptions.js b/www/manager6/panel/BackupAdvancedOptions.js
index baa35e7f..a7b0fc2b 100644
--- a/www/manager6/panel/BackupAdvancedOptions.js
+++ b/www/manager6/panel/BackupAdvancedOptions.js
@@ -272,14 +272,14 @@ Ext.define('PVE.panel.BackupAdvancedOptions', {
 		value: '__default__',
 		comboItems: [
 		    ['__default__', "Default"],
-		    ['data', "Data (experimental)"],
-		    ['metadata', "Metadata (experimental)"],
+		    ['data', "Data"],
+		    ['metadata', "Metadata"],
 		],
 	    },
 	    endFlex: 2,
 	    endColumn: {
 		xtype: 'displayfield',
-		value: gettext("Mode to detect file changes and switch archive encoding format for container backups (NOTE: `data` and `metadata` modes are experimental)."),
+		value: gettext("Mode to detect file changes and switch archive encoding format for container backups."),
 	    },
 	},
 	{
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [pve-devel] [PATCH docs] docs: drop experimental warning for change detection modes
  2024-11-11 11:55 [pve-devel] [PATCH manager] ui: remove experimental from change detection modes description Christian Ebner
@ 2024-11-11 11:55 ` Christian Ebner
  2024-11-17 17:36 ` [pve-devel] applied: [PATCH manager] ui: remove experimental from change detection modes description Thomas Lamprecht
  1 sibling, 0 replies; 3+ messages in thread
From: Christian Ebner @ 2024-11-11 11:55 UTC (permalink / raw)
  To: pve-devel

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 vzdump.adoc | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/vzdump.adoc b/vzdump.adoc
index 6f4cfc2..aecb353 100644
--- a/vzdump.adoc
+++ b/vzdump.adoc
@@ -196,12 +196,12 @@ There are 3 change detection modes available:
 | Mode     | Description
 | Default  | Read and encode all files into a single archive, using the pxar
 format version 1.
-| Data     | (EXPERIMENTAL): Read and encode all files, but split data and
-metadata into separate streams, using the pxar format version 2.
-| Metadata | (EXPERIMENTAL): Split streams and use archive format version 2 like
-`Data`, but use the metadata archive of the previous snapshot (if one exists) to
-detect unchanged files, and reuse their data chunks without reading file
-contents from disk, whenever possible.
+| Data     | Read and encode all files, but split data and metadata into
+separate streams, using the pxar format version 2.
+| Metadata | Split streams and use archive format version 2 like `Data`, but use
+the metadata archive of the previous snapshot (if one exists) to detect
+unchanged files, and reuse their data chunks without reading file contents from
+disk, whenever possible.
 |===============================================================================
 
 To perform a backup using the change detecation mode `metadata` you can run
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [pve-devel] applied: [PATCH manager] ui: remove experimental from change detection modes description
  2024-11-11 11:55 [pve-devel] [PATCH manager] ui: remove experimental from change detection modes description Christian Ebner
  2024-11-11 11:55 ` [pve-devel] [PATCH docs] docs: drop experimental warning for change detection modes Christian Ebner
@ 2024-11-17 17:36 ` Thomas Lamprecht
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Lamprecht @ 2024-11-17 17:36 UTC (permalink / raw)
  To: Proxmox VE development discussion, Christian Ebner

Am 11.11.24 um 12:55 schrieb Christian Ebner:
> As no issues with the change detection mode set to `metadata` or
> `data` have been reported during the prolonged test period, drop the
> `experimental` warnings from the description.
> 
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
>  www/manager6/panel/BackupAdvancedOptions.js | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
>

applied both patches, thanks!

next step might be to change the default for the next major release, if this works
out well.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-11-17 17:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-11 11:55 [pve-devel] [PATCH manager] ui: remove experimental from change detection modes description Christian Ebner
2024-11-11 11:55 ` [pve-devel] [PATCH docs] docs: drop experimental warning for change detection modes Christian Ebner
2024-11-17 17:36 ` [pve-devel] applied: [PATCH manager] ui: remove experimental from change detection modes description Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal