From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: Hannes Laimer <h.laimer@proxmox.com>
Cc: pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [PATCH pmg-api/pmg-gui v3 0/2] fix #3450: batch deletion/delivery for postfix queue
Date: Fri, 26 Sep 2025 11:16:24 +0200 [thread overview]
Message-ID: <s8oldm1efpz.fsf@proxmox.com> (raw)
In-Reply-To: <20250924071314.41917-1-h.laimer@proxmox.com> (Hannes Laimer's message of "Wed, 24 Sep 2025 09:13:12 +0200")
Hannes Laimer <h.laimer@proxmox.com> writes:
> Adds a new POST endpoint that accepts both a type(delete/deliver) and a
> list of id's. This is also how batch operations are done for quarantine.
>
> https://bugzilla.proxmox.com/show_bug.cgi?id=3450
>
> v3, thanks @Thomas:
> - code cleanup
> - add more context to commit messages
> - remove not needed checks when passing a list of ids to `postsuper -d -`
> - ui: use INFO instead of WARNING confirm popup, same as we do for quarantine
> - ui: no confirmation for flush of single mails, so existing behaviour of the
> button does not change
>
> v2:
> - instead of 'filter' use the IDs directly
> - UI now doesn't have extra buttons, the existing Remove and Flush ones
> will just work with either one or multiple selected items
I tested the changes and the UX is as expected. Only issue I had is that
the checkbox is too small to click manually when not using the filter,
but that seems to be out-of-scope for the current series.
The changes to pmg-api look OK to me. It is a bit unfortunate to
potentially loop over a big number of `postqueue -i` calls in
flush_queue_ids but from reading their man page I don't think they offer
a better alternative.
Tested-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
--
Maximiliano
_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
prev parent reply other threads:[~2025-09-26 9:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-24 7:13 Hannes Laimer
2025-09-24 7:13 ` [pmg-devel] [PATCH pmg-api v3 1/1] fix #3450: api: queue: add POST endpoint for batch deletion/delivery Hannes Laimer
2025-09-24 7:13 ` [pmg-devel] [PATCH pmg-gui v3 1/1] fix #3450: ui: queue: multi-select for item deletion/delivery Hannes Laimer
2025-09-26 9:16 ` Maximiliano Sandoval [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s8oldm1efpz.fsf@proxmox.com \
--to=m.sandoval@proxmox.com \
--cc=h.laimer@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox