* [pmg-devel] [PATCH pmg-gui v3 2/2] mail-proxy-relaying: add help to Default Relay
2023-09-14 13:18 [pmg-devel] [PATCH pmg-gui v3 1/2] mail-proxy-relaying: format function arguments Maximiliano Sandoval
@ 2023-09-14 13:18 ` Maximiliano Sandoval
2023-12-14 14:02 ` Maximiliano Sandoval
2023-12-15 15:31 ` [pmg-devel] applied-series: [PATCH pmg-gui v3 1/2] mail-proxy-relaying: format function arguments Stoiko Ivanov
1 sibling, 1 reply; 4+ messages in thread
From: Maximiliano Sandoval @ 2023-09-14 13:18 UTC (permalink / raw)
To: pmg-devel
Add link to [1].
[1] https://pmg.proxmox.com/pmg-docs/chapter-pmgconfig.html#pmgconfig_mailproxy_relaying
Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
Differences from v2:
- Add the link to all buttons in this panel.
js/MailProxyRelaying.js | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/js/MailProxyRelaying.js b/js/MailProxyRelaying.js
index 411c9b4..8b91aef 100644
--- a/js/MailProxyRelaying.js
+++ b/js/MailProxyRelaying.js
@@ -10,6 +10,7 @@ Ext.define('PMG.MailProxyRelaying', {
me.add_text_row('relay', gettext('Default Relay'), {
deleteEmpty: true,
defaultValue: Proxmox.Utils.noneText,
+ onlineHelp: 'pmgconfig_mailproxy_relaying',
});
me.add_integer_row('relayport', gettext('Relay Port'), {
@@ -17,6 +18,7 @@ Ext.define('PMG.MailProxyRelaying', {
deleteEmpty: true,
minValue: 1,
maxValue: 65535,
+ onlineHelp: 'pmgconfig_mailproxy_relaying',
});
me.add_combobox_row('relayprotocol', gettext('Relay Protocol'), {
@@ -24,10 +26,13 @@ Ext.define('PMG.MailProxyRelaying', {
comboItems: [
['smtp', 'SMTP'],
['lmtp', 'LMTP']],
+ onlineHelp: 'pmgconfig_mailproxy_relaying',
});
- me.add_boolean_row('relaynomx', gettext('Disable MX lookup (SMTP)'));
+ me.add_boolean_row('relaynomx', gettext('Disable MX lookup (SMTP)'), {
+ onlineHelp: 'pmgconfig_mailproxy_relaying',
+ });
me.rows.smarthost = {
required: true,
@@ -79,6 +84,7 @@ Ext.define('PMG.MailProxyRelaying', {
},
],
},
+ onlineHelp: 'pmgconfig_mailproxy_relaying',
};
me.rows.smarthostport = { visible: false };
--
2.39.2
^ permalink raw reply [flat|nested] 4+ messages in thread* [pmg-devel] applied-series: [PATCH pmg-gui v3 1/2] mail-proxy-relaying: format function arguments
2023-09-14 13:18 [pmg-devel] [PATCH pmg-gui v3 1/2] mail-proxy-relaying: format function arguments Maximiliano Sandoval
2023-09-14 13:18 ` [pmg-devel] [PATCH pmg-gui v3 2/2] mail-proxy-relaying: add help to Default Relay Maximiliano Sandoval
@ 2023-12-15 15:31 ` Stoiko Ivanov
1 sibling, 0 replies; 4+ messages in thread
From: Stoiko Ivanov @ 2023-12-15 15:31 UTC (permalink / raw)
To: Maximiliano Sandoval; +Cc: pmg-devel
applied both patches - thanks!
On Thu, Sep 14, 2023 at 03:18:12PM +0200, Maximiliano Sandoval wrote:
> In the next commit we add a new parameter.
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> js/MailProxyRelaying.js | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/js/MailProxyRelaying.js b/js/MailProxyRelaying.js
> index ace9575..411c9b4 100644
> --- a/js/MailProxyRelaying.js
> +++ b/js/MailProxyRelaying.js
> @@ -7,8 +7,10 @@ Ext.define('PMG.MailProxyRelaying', {
> initComponent: function() {
> var me = this;
>
> - me.add_text_row('relay', gettext('Default Relay'),
> - { deleteEmpty: true, defaultValue: Proxmox.Utils.noneText });
> + me.add_text_row('relay', gettext('Default Relay'), {
> + deleteEmpty: true,
> + defaultValue: Proxmox.Utils.noneText,
> + });
>
> me.add_integer_row('relayport', gettext('Relay Port'), {
> defaultValue: 25,
> --
> 2.39.2
>
>
>
> _______________________________________________
> pmg-devel mailing list
> pmg-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread