From: Christoph Heiss <c.heiss@proxmox.com>
To: pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [PATCH pmg-gui] css: fix icon/text alignment in panel headers for Firefox
Date: Wed, 9 Aug 2023 16:33:43 +0200 [thread overview]
Message-ID: <pkimml6akmnfcsvb437xgcf33dvsvqgjgowizt6rla3mma6fcz@luuk36saz3dk> (raw)
In-Reply-To: <20230809100739.423147-1-c.heiss@proxmox.com>
Just noticed this is broken in PBS as well.
I guess it should be then fixed in proxmox-widget-toolkit directly? Or
rather separately?
On Wed, Aug 09, 2023 at 12:07:37PM +0200, Christoph Heiss wrote:
>
> Add `vertial-align: text-top` to all panel header icons - for the
> accompanying text, this already gets set through the `.x-tab-inner`
> class.
>
> Without this, in Firefox (116.0.1, at least) the icon and the text would
> be slightly offset vertically - due to different baselines, I'd guess.
> Chromium seems fine w/ and w/o the patch, no change there.
>
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
> css/ext6-pmg.css | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/css/ext6-pmg.css b/css/ext6-pmg.css
> index 2f999f4..68e5b7a 100644
> --- a/css/ext6-pmg.css
> +++ b/css/ext6-pmg.css
> @@ -180,6 +180,10 @@ table:not(.x-grid-item-selected) tr.x-grid-row.disabled {
> height: initial;
> }
>
> +.x-tab-icon-el {
> + vertical-align: text-top;
> +}
> +
> tr.x-grid-row-summary td.x-grid-cell {
> border-top: 1px solid black;
> font-weight: bold;
> --
> 2.41.0
>
>
>
> _______________________________________________
> pmg-devel mailing list
> pmg-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
>
>
next prev parent reply other threads:[~2023-08-09 14:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 10:07 Christoph Heiss
2023-08-09 14:33 ` Christoph Heiss [this message]
2023-09-12 14:15 ` Stoiko Ivanov
2023-09-13 8:05 ` Thomas Lamprecht
2023-09-14 7:00 ` Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pkimml6akmnfcsvb437xgcf33dvsvqgjgowizt6rla3mma6fcz@luuk36saz3dk \
--to=c.heiss@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox