From: Dominik Csapak <d.csapak@proxmox.com>
To: Stoiko Ivanov <s.ivanov@proxmox.com>, pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [PATCH pmg-api v2 0/4] improve local mail injection and add smtputf8 support
Date: Thu, 16 Mar 2023 13:52:41 +0100 [thread overview]
Message-ID: <ff373e8b-6f0a-7ac7-54d2-373de865b473@proxmox.com> (raw)
In-Reply-To: <20230308145235.37342-1-s.ivanov@proxmox.com>
2 high level comments
(one we already talked off-list, just to have it on record)
1. it seems that with this, at least the receiver gets encoded too many
times, since i get a different recipient (with non-ascii characters)
when hitting an ACCEPT rule vs. hitting a QUARANTINE rule and
delivering it (not sure which patch is the faulty one here,
but i guess api 4/4?)
2. AFAICS for 'reinject_local_mail' we decide to put SMTPUTF8 when
the sender/receiver has non-ascii characters
shouldn't we also make this depend on the config smtputf8 setting?
since when we accept a mail right through, we don't scan the
receiver/sender for that when no smtputf8 is set
(postfix docs say here that they don't accept utf8
without SMTPUTF8 dialog, but it worked when testing here...)
but do so when it goes into quarantine + deliver
rationale is that when i have to disable smtputf8 support,
it's because my downstream mail server does not accept it.
in that case, every attempt to send such a mail will fail
making the quarantine, etc. useless
what do you think?
next prev parent reply other threads:[~2023-03-16 12:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 14:52 Stoiko Ivanov
2023-03-08 14:52 ` [pmg-devel] [PATCH pmg-docs v2 1/1] doc-generator: add new option smtputf8 Stoiko Ivanov
2023-03-08 14:52 ` [pmg-devel] [PATCH pmg-api v2 1/4] smtputf8: keep smtputf8 from incoming postfix, detect for local mail Stoiko Ivanov
2023-03-08 14:52 ` [pmg-devel] [PATCH pmg-api v2 2/4] config: make smtputf8 configurable through the API Stoiko Ivanov
2023-03-08 14:52 ` [pmg-devel] [PATCH pmg-api v2 3/4] reinject mail: improve error logging Stoiko Ivanov
2023-03-08 14:52 ` [pmg-devel] [PATCH pmg-api v2 4/4] quarantine: use reinject_local_mail to deliver quarantined mail Stoiko Ivanov
2023-03-08 14:52 ` [pmg-devel] [PATCH pmg-gui v2 1/1] mail proxy options: add smtputf8 checkbox Stoiko Ivanov
2023-03-16 12:52 ` Dominik Csapak [this message]
2023-03-16 12:58 ` [pmg-devel] [PATCH pmg-api v2 0/4] improve local mail injection and add smtputf8 support Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff373e8b-6f0a-7ac7-54d2-373de865b473@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox