From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Markus Frank <m.frank@proxmox.com>, pmg-devel@lists.proxmox.com
Subject: [pmg-devel] applied: [PATCH pmg-api v2 2/2] fix #3924: ldap: accept only valid email-address
Date: Wed, 6 Apr 2022 10:12:50 +0200 [thread overview]
Message-ID: <fe20a340-201a-f473-443d-6bf0b7de5e91@proxmox.com> (raw)
In-Reply-To: <20220330123215.41926-2-m.frank@proxmox.com>
On 30.03.22 14:32, Markus Frank wrote:
> If a mail attribute contains special characters in ldap at the first
> line, it will be set as primary email and results in a
> "400 invalid format - value does not look like a valid email address"
> Error-Statement in the webconsole. This mostly can happen if SIP
> Addresses are in Active-Directory's proxyAddresses which begin with "SIP:".
>
> To make the validation more strict I changed the api to use
> pmg-email-address and added a regex which looks for protocolnames (sip:)
> that could be in proxyAddresses but are not compatible and skips these
> addresses.
>
> Signed-off-by: Markus Frank <m.frank@proxmox.com>
> ---
> src/PMG/API2/LDAP.pm | 5 ++---
> src/PMG/LDAPCache.pm | 8 +++++++-
> 2 files changed, 9 insertions(+), 4 deletions(-)
>
>
applied, thanks! Fixed up a few (trailing/extra) whitespace errors and shortened
the m$ link.
next prev parent reply other threads:[~2022-04-06 8:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 12:32 [pmg-devel] [PATCH pmg-api v2 1/2] removed SMTP from regex Markus Frank
2022-03-30 12:32 ` [pmg-devel] [PATCH pmg-api v2 2/2] fix #3924: ldap: accept only valid email-address Markus Frank
2022-04-06 8:12 ` Thomas Lamprecht [this message]
2022-04-04 13:33 ` [pmg-devel] applied: [PATCH pmg-api v2 1/2] removed SMTP from regex Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe20a340-201a-f473-443d-6bf0b7de5e91@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=m.frank@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox