public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Stoiko Ivanov <s.ivanov@proxmox.com>, pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [PATCH pmg-docs v2 1/1] certs: add wildcard certificate support
Date: Tue, 13 Apr 2021 07:07:00 +0200	[thread overview]
Message-ID: <fa07d444-264f-2686-adca-3704aeb37ad6@proxmox.com> (raw)
In-Reply-To: <20210412192833.21988-4-s.ivanov@proxmox.com>

On 12.04.21 21:28, Stoiko Ivanov wrote:
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
>  pmg-ssl-certificate.adoc | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/pmg-ssl-certificate.adoc b/pmg-ssl-certificate.adoc
> index 6cd44b1..24e8d71 100644
> --- a/pmg-ssl-certificate.adoc
> +++ b/pmg-ssl-certificate.adoc
> @@ -187,6 +187,23 @@ and set the `alias` property in the {pmg} node configuration file
>  `/etc/pmg/node.conf` to `domain2.example` to allow the DNS server of
>  `domain2.example` to validate all challenges for `domain1.example`.
>  
> +[[sysadmin_certs_acme_dns_wildcard]]
> +Wildcard Certificates
> +^^^^^^^^^^^^^^^^^^^^^
> +You can create a certificate for a 'wildcard DNS name' as described in

why the single quotes? I'd rather go for something like

"You can create wildcard certificates with the DNS challenge type."

> +https://community.letsencrypt.org/t/acme-v2-production-environment-wildcards/55578[ACME v2 Production Environment & Wildcards].

Maybe rather link:
https://letsencrypt.org/docs/challenge-types/#dns-01-challenge


> +
> +Wildcard DNS names start with a `*.` prefix and are considered valid for all
> +(one-level) subdomain names of the verified domain. So a certificate for
> +`*.domain.example` is valid for example for `foo.domain.example` and
> +`bar.domain.example`.

above paragraph should come first, as it's the actual introduction to wildcards.
A example for not being valid for deeper level would also help, something like:

"is valid for example for `foo.domain.example` and `bar.domain.example`, but not
for `baz.foo.domain.example`."

> +
> +Verification for wildcard DNS names only works with the `dns-01` validation
> +method.
> +

We should probably check above in the frontend and backend for better UX.

> +You need to configure both the base domain (`domain.example`) as well as the
> +wildcard equivalent (`*.domain.example`) under `Certificates` with a DNS plugin.
> +

above paragraph is wrong.

>  
>  Combination of Plugins
>  ^^^^^^^^^^^^^^^^^^^^^^
> 





  reply	other threads:[~2021-04-13  5:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-12 19:28 [pmg-devel] [PATCH pmg-api/pmg-docs/proxmox-widget-toolkit v2 0/1] allow wildcard DNS-names for ACME Stoiko Ivanov
2021-04-12 19:28 ` [pmg-devel] [PATCH pmg-api v2 1/1] acme: allow wildcard domain entries Stoiko Ivanov
2021-04-15 13:18   ` [pmg-devel] applied: " Thomas Lamprecht
2021-04-12 19:28 ` [pmg-devel] [PATCH v2 proxmox-widget-toolkit 1/1] acme: allow wildcards as domain Stoiko Ivanov
2021-04-12 19:28 ` [pmg-devel] [PATCH pmg-docs v2 1/1] certs: add wildcard certificate support Stoiko Ivanov
2021-04-13  5:07   ` Thomas Lamprecht [this message]
2021-04-13  4:55 ` [pmg-devel] [PATCH pmg-api/pmg-docs/proxmox-widget-toolkit v2 0/1] allow wildcard DNS-names for ACME Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa07d444-264f-2686-adca-3704aeb37ad6@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    --cc=s.ivanov@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal