* [pmg-devel] [PATCH pmg-api] api: relaod ruledb on updating objecgroups
@ 2024-02-22 10:04 Dominik Csapak
2024-02-22 10:06 ` Dominik Csapak
2024-02-22 13:18 ` [pmg-devel] applied: " Stoiko Ivanov
0 siblings, 2 replies; 3+ messages in thread
From: Dominik Csapak @ 2024-02-22 10:04 UTC (permalink / raw)
To: pmg-devel
previously they only contained metadata (name/comment) so for the
rulesystem that was not relevant. Now with the attributes and/invert
we want to reload the ruledb on update too.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
src/PMG/API2/ObjectGroupHelpers.pm | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/PMG/API2/ObjectGroupHelpers.pm b/src/PMG/API2/ObjectGroupHelpers.pm
index 3060157..fabfa6a 100644
--- a/src/PMG/API2/ObjectGroupHelpers.pm
+++ b/src/PMG/API2/ObjectGroupHelpers.pm
@@ -289,6 +289,8 @@ sub register_object_group_config_api {
$rdb->save_group($og);
+ PMG::DBTools::reload_ruledb();
+
return undef;
}});
}
--
2.30.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [pmg-devel] [PATCH pmg-api] api: relaod ruledb on updating objecgroups
2024-02-22 10:04 [pmg-devel] [PATCH pmg-api] api: relaod ruledb on updating objecgroups Dominik Csapak
@ 2024-02-22 10:06 ` Dominik Csapak
2024-02-22 13:18 ` [pmg-devel] applied: " Stoiko Ivanov
1 sibling, 0 replies; 3+ messages in thread
From: Dominik Csapak @ 2024-02-22 10:06 UTC (permalink / raw)
To: pmg-devel
argh... sorry for the typo in the subject... i can send a v2 or it can
be fixed up when applying...
^ permalink raw reply [flat|nested] 3+ messages in thread
* [pmg-devel] applied: [PATCH pmg-api] api: relaod ruledb on updating objecgroups
2024-02-22 10:04 [pmg-devel] [PATCH pmg-api] api: relaod ruledb on updating objecgroups Dominik Csapak
2024-02-22 10:06 ` Dominik Csapak
@ 2024-02-22 13:18 ` Stoiko Ivanov
1 sibling, 0 replies; 3+ messages in thread
From: Stoiko Ivanov @ 2024-02-22 13:18 UTC (permalink / raw)
To: Dominik Csapak; +Cc: pmg-devel
Thanks for finding and fixing this!
applied the patch, with the 2 typos in the subject line fixed up,
after testing it (watching the journal while sending mails before/after,
looking for
`pmg-smtp-filter[333766]: reloading configuration Proxmox_ruledb` )
On Thu, 22 Feb 2024 11:04:57 +0100
Dominik Csapak <d.csapak@proxmox.com> wrote:
> previously they only contained metadata (name/comment) so for the
> rulesystem that was not relevant. Now with the attributes and/invert
> we want to reload the ruledb on update too.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> src/PMG/API2/ObjectGroupHelpers.pm | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/src/PMG/API2/ObjectGroupHelpers.pm b/src/PMG/API2/ObjectGroupHelpers.pm
> index 3060157..fabfa6a 100644
> --- a/src/PMG/API2/ObjectGroupHelpers.pm
> +++ b/src/PMG/API2/ObjectGroupHelpers.pm
> @@ -289,6 +289,8 @@ sub register_object_group_config_api {
>
> $rdb->save_group($og);
>
> + PMG::DBTools::reload_ruledb();
> +
> return undef;
> }});
> }
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-22 13:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-22 10:04 [pmg-devel] [PATCH pmg-api] api: relaod ruledb on updating objecgroups Dominik Csapak
2024-02-22 10:06 ` Dominik Csapak
2024-02-22 13:18 ` [pmg-devel] applied: " Stoiko Ivanov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox