public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Fabian Ebner <f.ebner@proxmox.com>, pmg-devel@lists.proxmox.com
Subject: [pmg-devel] applied: [PATCH widget-toolkit] sorters: use correct property 'direction' and keep default 'ASC'
Date: Thu, 10 Feb 2022 13:56:46 +0100	[thread overview]
Message-ID: <e399c7df-3390-97a0-e4b1-f4c2deb84b60@proxmox.com> (raw)
In-Reply-To: <20211207115331.67545-1-f.ebner@proxmox.com>

On 07.12.21 12:53, Fabian Ebner wrote:
> Ext.util.Sorter does not have an 'order' property, so 'order: DESC'
> didn't have an effect. The default is 'ASC' and it is arguably the
> preferred direction for realm anyways.
> 
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> 
> I'll also send a patch for PVE later. PBS doesn't have this mistake
> anywhere AFAICS.
> 
>  src/panel/AuthView.js     | 2 +-
>  src/window/ACMEAccount.js | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
>

applied, thanks!




      parent reply	other threads:[~2022-02-10 12:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-07 11:53 [pmg-devel] " Fabian Ebner
2021-12-07 11:53 ` [pmg-devel] [PATCH pmg-gui] " Fabian Ebner
2022-02-03 11:33   ` [pmg-devel] applied: " Thomas Lamprecht
2022-02-10 12:56 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e399c7df-3390-97a0-e4b1-f4c2deb84b60@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal