Re: [pmg-devel] [PATCH pmg-api v1] proxy: add support for switching themes

[Stefan Sterz <s.sterz@proxmox.com>]

On 3/10/23 11:14, Dominik Csapak wrote:
> replying here for the whole pmg part of the series
> 
> all in all LGTM
> 
> besides apart from some minor stuff that
> can be done as a follow-up:
> 
> * in some parts the indentation is wrong
> * the mobile quarantine has still white dialogs
>   (seems to be a bug in the framework7 version we use, updating
>   to a current version seems non-trivial since we're 3 major
>   versions behind, i can do it of course if wanted)

i noticed that too, there are other issues that i still need to fix too
(e.g., the logo on the login screen). but yeah, updating is probably the
way to go here. since the mobile quarantine also displays the mail with
a white background at the moment, i considered the dialogs a minor issue
in comparison. i can also take a look at updating framework7 once i got
some other fix-ups out.

> * regarding the quarantine theme toggle:
>   why should it not be possible to have a theme toggle when we respect
> the cookie?
>   we can just read the parameter and as a fallback rely on the cookie?
>   imho that would be a cleaner solution than inverting the whole mail
> 

well, you'd need to reload the mail preview with every toggle, afaict.
that's what i meant with "not easily". but yes, that would be possible.
hence, my comment in that patch.

> if these points are not a problem @Thomas/@Stoiko, consider the pmg part
> 
> Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
> Tested-by: Dominik Csapak <d.csapak@proxmox.com>
>