public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Stoiko Ivanov <s.ivanov@proxmox.com>, pmg-devel@lists.proxmox.com
Subject: [pmg-devel] applied: [PATCH pmg-api v2] pmg-daily: avoid short-circuting update of local channels
Date: Wed, 13 Jul 2022 11:13:22 +0200	[thread overview]
Message-ID: <e1c41767-72af-29c5-fa1e-b13332ad7c39@proxmox.com> (raw)
In-Reply-To: <20220713090935.4725-1-s.ivanov@proxmox.com>

Am 13/07/2022 um 11:09 schrieb Stoiko Ivanov:
> by using ||= directly with the actual update call, it does not get
> run, if `sa-update` already returned that a restart is needed.
> 
> reported in our community forum:
> https://forum.proxmox.com/threads/.112112/
> 
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> v1->v2:
> * dropped the temporary variable in favor of a post-if (more in line
>   with our remaining code - and actually prettier imho) - thx@Thomas
>   for the suggestion!
>  src/bin/pmg-daily | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied, thanks!




      reply	other threads:[~2022-07-13  9:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-13  9:09 [pmg-devel] " Stoiko Ivanov
2022-07-13  9:13 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e1c41767-72af-29c5-fa1e-b13332ad7c39@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    --cc=s.ivanov@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal