public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>, pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [PATCH pmg-gui v2] StatTimeSelector: don't show invalid month/day combinations
Date: Fri, 1 Jul 2022 13:36:13 +0200	[thread overview]
Message-ID: <d5d7e6c2-83b7-89f6-2230-b291b52a5008@proxmox.com> (raw)
In-Reply-To: <3ac30ae3-8d45-3795-8afd-f24657f7ccd0@proxmox.com>

On 01/07/2022 11:57, Dominik Csapak wrote:
> although the comment does not fit in 100 columns here (takes up 103)
> would that be still ok, or should i try to find an even shorter
> sentence?

argh, missed one indentation level (clocked in at 99 here).. fine with either.

> 
> (also after looking at it again, i'd use 'lookup' instead of
> 'lookupReference' since that's only an alias and much shorter)

good call




      reply	other threads:[~2022-07-01 11:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-01  8:03 Dominik Csapak
2022-07-01  9:32 ` Thomas Lamprecht
2022-07-01  9:57   ` Dominik Csapak
2022-07-01 11:36     ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d5d7e6c2-83b7-89f6-2230-b291b52a5008@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal