public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
	Maximiliano Sandoval <m.sandoval@proxmox.com>,
	pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [PATCH pmg-gui v2] js/BackupConfiguration: Add icons to tab buttons
Date: Wed, 6 Sep 2023 11:33:17 +0200	[thread overview]
Message-ID: <d5b0d556-137d-4caa-8fc9-a7b555ecb8f0@proxmox.com> (raw)
In-Reply-To: <7070fc25-624b-4baa-a8e3-4542b0891d5f@proxmox.com>

On 9/6/23 11:28, Thomas Lamprecht wrote:
>>
>> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
>> ---
>> Differences from v1:
>>    - Use the `fa-database` icon for local backups as suggested by Dominik
> 
> where has this been suggested? I see no review on the list..
> Please keep reviews public and not in some silo, if you really want to talk
> off list it can be fine, but the summary of that discussion needs to go
> on the mailing lists, either by Dominik suggesting that or by you replying
> to v1 that it's will be replaced by a v2 due to said suggestion from Dominik.
> 
> I'd find the folder icon a slightly better fit for something local, like we
> use for local storage's in the storageSchema in Proxmox VE, but no hard
> feelings from my side – just wondering why database over that..

sorry that was probably my fault :S

Maximiliano asked me off list what i liked better, and i answered without too much thinking
of it (did not notice the v1 on the list at that point yet)

after thinking about it, i agree with thomas, that the 'folder' icon is even better,
is more consistent with pve (as that uses it for local storage too)

sorry again for the confusion


> 
>>    
>>   js/BackupConfiguration.js | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/js/BackupConfiguration.js b/js/BackupConfiguration.js
>> index e21771f..7122822 100644
>> --- a/js/BackupConfiguration.js
>> +++ b/js/BackupConfiguration.js
>> @@ -12,11 +12,13 @@ Ext.define('PMG.BackupConfiguration', {
>>   	    itemId: 'local',
>>   	    title: gettext('Local Backup/Restore'),
>>   	    xtype: 'pmgBackupRestore',
>> +	    iconCls: 'fa fa-database',
>>   	},
>>   	{
>>   	    itemId: 'proxmoxbackupserver',
>>   	    title: 'Proxmox Backup Server',
>>   	    xtype: 'pmgPBSConfig',
>> +	    iconCls: 'fa fa-floppy-o',
>>   	},
>>      ],
>>   });
> 





      reply	other threads:[~2023-09-06  9:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-06  6:55 Maximiliano Sandoval
2023-09-06  9:28 ` Thomas Lamprecht
2023-09-06  9:33   ` Dominik Csapak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d5b0d556-137d-4caa-8fc9-a7b555ecb8f0@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=m.sandoval@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal