public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Stoiko Ivanov <s.ivanov@proxmox.com>, pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [PATCH pmg-api] sa-custom: fix moving config across mountpoints
Date: Thu, 3 Oct 2024 17:27:34 +0200	[thread overview]
Message-ID: <cf324dba-cafb-4da1-a825-212db1220579@proxmox.com> (raw)
In-Reply-To: <20241002172238.20947-1-s.ivanov@proxmox.com>

On 02/10/2024 19:22, Stoiko Ivanov wrote:
> the custom scores are kept in /var/cache/pmg-scores.cf, until they are
> applied, by moving them to /etc/mail/spamassassin/pmg-scores.cf.

Is there a good reason to not keep them in "/etc/mail/spamassassin/"
instead? That would ensure a simple rename can work and be IMO a bit
more in line with what we do else where (like host network changes),
and using "/var/cache" here feels also a bit odd in general, but that
doesn't have to be the deciding factor.

I'm fine with switching to move, but IMO adding a short info for why
not changing the pending changes config file path to the same directory
might be warranted.

> @@ -14,7 +15,9 @@ sub get_shadow_path {
>  }
>  
>  sub apply_changes {
> -    rename($shadow_path, $conf_path) if -f $shadow_path;
> +    if (-f $shadow_path) {
> +	move($shadow_path, $conf_path) || die 'Moving custom scores configuration failed!\n';

is there no error variable?

With rename we could at least do

if (-f $shadow_path) {
    rename($shadow_path, $conf_path) or die "failed to apply custom scores - $!\n";
}

(which would have made exposing that bug much easier in the first place ^^)

> +    }
>  }
>  
>  sub calc_digest {



_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel


  reply	other threads:[~2024-10-03 15:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-02 17:22 Stoiko Ivanov
2024-10-03 15:27 ` Thomas Lamprecht [this message]
2024-10-04  8:41 ` Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cf324dba-cafb-4da1-a825-212db1220579@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    --cc=s.ivanov@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal