public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Stoiko Ivanov <s.ivanov@proxmox.com>, pmg-devel@lists.proxmox.com
Subject: [pmg-devel] applied: [PATCH pmg-api] pmgdb: dump: replace active flag with rules enum
Date: Tue, 27 Feb 2024 17:01:40 +0100	[thread overview]
Message-ID: <cc9d5bd8-12f4-4cc3-ac98-c2a87f776f27@proxmox.com> (raw)
In-Reply-To: <20240227142203.233611-1-s.ivanov@proxmox.com>

Am 27/02/2024 um 15:22 schrieb Stoiko Ivanov:
> this addresses the odd/unintuitive behavior of `pmgdb dump --active 0`
> which currently prints all rules, why printing only the inactive ones
> might be expected.
> 
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> tested by running all 4 variants (active, inactive, all, no rule argument)
> and diffing the resulting output)
>  src/PMG/CLI/pmgdb.pm | 18 +++++++++++-------
>  1 file changed, 11 insertions(+), 7 deletions(-)
> 
>

While I shortly thought if another option name would be better (e.g.,
rule-selection?), this is mostly for debugging purpose, so I think it
won't matter much anyway.

applied, thanks!




      reply	other threads:[~2024-02-27 16:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-27 14:22 [pmg-devel] " Stoiko Ivanov
2024-02-27 16:01 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cc9d5bd8-12f4-4cc3-ac98-c2a87f776f27@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    --cc=s.ivanov@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal