public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: Mira Limbeck <m.limbeck@proxmox.com>, pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [PATCH v3 pmg-log-tracker 1/5] rfc3339: move timezone offset compatibility code to old time parser
Date: Thu, 22 Feb 2024 13:25:20 +0100	[thread overview]
Message-ID: <ca701227-c360-4294-afe1-3987d7a476ca@proxmox.com> (raw)
In-Reply-To: <20240220100648.44119-1-m.limbeck@proxmox.com>

Gave this series a look & spin

code wise looks good imho

as mentioned off-list, we could fix the issue of the endtimes' offset
by adding the difference of offset of the end/start to the end cutoff
iff we encounter lines in the old format
(i.e. if the starttime was +1 and the endtime was +2, we have to
subtract +2 - +1 = 1 from the endtime for the old log format)

but that should not make too much difference in practice, as the
old log format was broken anyway in some circumstances

all in all i think this change is a net positive, since the time
returned by the log-tracker is now the "real" unix epoch
and we can drop the local timezone offset when we have the exact time
(which is most of the time now for current installations)

we probably should mention that the non exactly syslog format is
deprecated though and can create problems/confusion in the log tracker

tested with my local logs (no old format left sadly) and played around
with the test cases with the old format and found no issues

(how i hate handling time(zones) manually :P )




  parent reply	other threads:[~2024-02-22 12:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-20 10:06 Mira Limbeck
2024-02-20 10:06 ` [pmg-devel] [PATCH v3 pmg-log-tracker 2/5] tests: improve test output consistency Mira Limbeck
2024-02-20 10:06 ` [pmg-devel] [PATCH v3 pmg-log-tracker 3/5] tests: update for log tracker time handling changes Mira Limbeck
2024-02-20 10:06 ` [pmg-devel] [PATCH v3 pmg-log-tracker 4/5] cleanup: remove unused strftime function Mira Limbeck
2024-02-20 10:06 ` [pmg-devel] [PATCH v3 pmg-log-tracker 5/5] cleanup: fix clippy warnings Mira Limbeck
2024-02-20 10:06 ` [pmg-devel] [PATCH v3 pmg-api] MailTracker: remove timezone offset Mira Limbeck
2024-02-22 12:25 ` Dominik Csapak [this message]
2024-02-27 14:07 ` [pmg-devel] applied-series: [PATCH v3 pmg-log-tracker 1/5] rfc3339: move timezone offset compatibility code to old time parser Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ca701227-c360-4294-afe1-3987d7a476ca@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=m.limbeck@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal