From: Dominik Csapak <d.csapak@proxmox.com>
To: Stoiko Ivanov <s.ivanov@proxmox.com>, pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [PATCH pmg-api] utils: finalize_report: fix encoding for plain-text parts
Date: Fri, 23 Jan 2026 11:46:10 +0100 [thread overview]
Message-ID: <c9ecf806-db2d-477e-9508-58de07145d8c@proxmox.com> (raw)
In-Reply-To: <20260123094022.8188-1-s.ivanov@proxmox.com>
though i didn't test this, the change looks good
and makes sense when reading the MIME::Entity docs and
the linked RFC
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
On 1/23/26 10:40 AM, Stoiko Ivanov wrote:
> the syntax for 8-bit encoding in the content-transfer-encoding is
> '8bit' not '8-bit' - see RFC2045:
> https://www.ietf.org/rfc/rfc2045.html#section-6
>
> We did set the correct value when generating bounces in SMTP.pm (the
> only other (non-comment) match for '8-?bit' in the pmg-api sources).
>
> Noticed this while checking why listmonk[0] stumbled on some bounce
> mails - it was the spam-reports in the mailbox.
>
> Minimally tested by comparing the output of:
> `pmgqm send --receiver xxx@test.domain --debug1`
> without and with the patch applied.
>
> [0] application for newsletter mailing lists
> https://github.com/knadh/listmonk
> Reported-by: Christian Ebner <c.ebner@proxmox.com>
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> src/PMG/Utils.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/PMG/Utils.pm b/src/PMG/Utils.pm
> index 52b98c01..b9c645eb 100644
> --- a/src/PMG/Utils.pm
> +++ b/src/PMG/Utils.pm
> @@ -1374,7 +1374,7 @@ sub finalize_report {
> $top->attach(
> Data => $plaintext,
> Type => 'text/plain; charset=utf-8',
> - Encoding => '8-bit',
> + Encoding => '8bit',
> );
> }
> if ($html) {
_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
prev parent reply other threads:[~2026-01-23 10:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-23 9:40 Stoiko Ivanov
2026-01-23 10:46 ` Dominik Csapak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9ecf806-db2d-477e-9508-58de07145d8c@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox