From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Stoiko Ivanov <s.ivanov@proxmox.com>, pmg-devel@lists.proxmox.com
Subject: [pmg-devel] applied-series: [PATCH pmg-api/pwt/pmg-docs v3]
Date: Tue, 13 Jul 2021 10:03:46 +0200 [thread overview]
Message-ID: <c4d20720-ad68-d499-3b86-6debffac4732@proxmox.com> (raw)
In-Reply-To: <20210415194622.25632-1-s.ivanov@proxmox.com>
On 15.04.21 21:46, Stoiko Ivanov wrote:
> v2->v3:
> * incorporated Thomas' excellent feedback (especially that part of wildcard-certs
> without the base-domain being added actually working despite my theoretical
> guess that it would not :)
> * added a check for wildcardcert needs DNS plugin during node-config parsing and writing
>
> original cover-letter for v2:
> v1->v2:
> * reaad up on the requirements and infered from [0], a few HOWTOs and the
> response from the LE staging directory that:
> ```
> Orders that contain both a base domain and its wildcard equivalent (...) are
> valid.
> ```
> means that only such orders are valid (hence the requirement for the base
> name in addition to the wildcard name
> * added a short stanza to pmg-docs describing the requirements
> * added a patch for pwt to allow '*.' as prefix for domains in ACMEDomains
>
>
> [0] https://community.letsencrypt.org/t/acme-v2-production-environment-wildcards/55578
>
> pmg-api:
> Stoiko Ivanov (3):
> acme: handle wildcard dns validation
> acme: check plugin for wildcard certificates
> nodeconfig: parse acme config before writing
>
> src/PMG/API2/Certificates.pm | 5 +++++
> src/PMG/NodeConfig.pm | 14 +++++++++++++-
> 2 files changed, 18 insertions(+), 1 deletion(-)
>
> promox-widget-toolkit:
> Stoiko Ivanov (1):
> acme: allow wildcards as domain
>
> src/Toolkit.js | 5 +++++
> src/Utils.js | 1 +
> src/window/ACMEDomains.js | 2 +-
> 3 files changed, 7 insertions(+), 1 deletion(-)
>
> pmg-docs:
> Stoiko Ivanov (1):
> certs: add wildcard certificate support
>
> pmg-ssl-certificate.adoc | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
applied series, thanks!
prev parent reply other threads:[~2021-07-13 8:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 19:46 [pmg-devel] " Stoiko Ivanov
2021-04-15 19:46 ` [pmg-devel] [PATCH pmg-api v3 1/3] acme: handle wildcard dns validation Stoiko Ivanov
2021-04-15 19:46 ` [pmg-devel] [PATCH pmg-api v3 2/3] acme: check plugin for wildcard certificates Stoiko Ivanov
2021-04-15 19:46 ` [pmg-devel] [PATCH pmg-api v3 3/3] nodeconfig: parse acme config before writing Stoiko Ivanov
2021-04-15 19:46 ` [pmg-devel] [PATCH v3 1/1] acme: allow wildcards as domain Stoiko Ivanov
2021-04-15 19:46 ` [pmg-devel] [PATCH pmg-docs v3 1/1] certs: add wildcard certificate support Stoiko Ivanov
2021-07-13 8:03 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4d20720-ad68-d499-3b86-6debffac4732@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox