public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pmg-devel] [PATCH pmg-gui] ui: allow 'info' field to be shown in object lists
@ 2024-08-09  5:49 Hannes Laimer
  2025-02-25 20:35 ` [pmg-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Hannes Laimer @ 2024-08-09  5:49 UTC (permalink / raw)
  To: pmg-devel

Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
came up in support, and I couldn't think of a good reason to not
have the option to show the description in the list

 js/ObjectGroupList.js | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/js/ObjectGroupList.js b/js/ObjectGroupList.js
index ab66e92..a2a1ea2 100644
--- a/js/ObjectGroupList.js
+++ b/js/ObjectGroupList.js
@@ -146,6 +146,14 @@ Ext.define('PMG.ObjectGroupList', {
 		    dataIndex: 'name',
 		    renderer: Ext.String.htmlEncode,
 		},
+		{
+		    header: gettext('Description'),
+		    sortable: true,
+		    flex: 1,
+		    dataIndex: 'info',
+		    renderer: Ext.String.htmlEncode,
+		    hidden: true,
+		},
 	    ],
 	    listeners: {
 		itemdblclick: function() {
-- 
2.39.2



_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pmg-devel] applied: [PATCH pmg-gui] ui: allow 'info' field to be shown in object lists
  2024-08-09  5:49 [pmg-devel] [PATCH pmg-gui] ui: allow 'info' field to be shown in object lists Hannes Laimer
@ 2025-02-25 20:35 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2025-02-25 20:35 UTC (permalink / raw)
  To: Hannes Laimer, pmg-devel

Am 09.08.24 um 07:49 schrieb Hannes Laimer:
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
> came up in support, and I couldn't think of a good reason to not
> have the option to show the description in the list
> 
>  js/ObjectGroupList.js | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
>

applied, thanks!

Could be worth to always show this and make the column a bit wider to accommodate
the higher space needs, as IMO it has some benefit to see all description in the
list at once compared to having to select each list element separately to see
its description a bit subtle in the tbar of the right panel. 


_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-02-25 20:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-09  5:49 [pmg-devel] [PATCH pmg-gui] ui: allow 'info' field to be shown in object lists Hannes Laimer
2025-02-25 20:35 ` [pmg-devel] applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal