From: Dominik Csapak <d.csapak@proxmox.com>
To: pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [PATCH widget-toolkit 2/7] add ACME related data models
Date: Thu, 11 Mar 2021 13:41:06 +0100 [thread overview]
Message-ID: <c1be6fc5-afa9-7a30-ce37-00dcbf93867f@proxmox.com> (raw)
In-Reply-To: <20210309141401.19237-13-w.bumiller@proxmox.com>
comments inline
On 3/9/21 3:13 PM, Wolfgang Bumiller wrote:
> Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
> ---
> src/Makefile | 2 ++
> src/data/model/ACME.js | 30 ++++++++++++++++++++++++++++++
> src/data/model/Certificates.js | 6 ++++++
> 3 files changed, 38 insertions(+)
> create mode 100644 src/data/model/ACME.js
> create mode 100644 src/data/model/Certificates.js
>
> diff --git a/src/Makefile b/src/Makefile
> index 46b90ae..3861bfc 100644
> --- a/src/Makefile
> +++ b/src/Makefile
> @@ -15,6 +15,8 @@ JSSRC= \
> data/RRDStore.js \
> data/TimezoneStore.js \
> data/model/Realm.js \
> + data/model/Certificates.js \
> + data/model/ACME.js \
> form/DisplayEdit.js \
> form/ExpireDate.js \
> form/IntegerField.js \
> diff --git a/src/data/model/ACME.js b/src/data/model/ACME.js
> new file mode 100644
> index 0000000..c05572e
> --- /dev/null
> +++ b/src/data/model/ACME.js
> @@ -0,0 +1,30 @@
> +Ext.define('proxmox-acme-accounts', {
> + extend: 'Ext.data.Model',
> + fields: ['name'],
> + proxy: {
> + type: 'proxmox',
> + //url: "/api2/json/cluster/acme/account",
i'd prefer not to have the commented out api paths here
> + },
> + idProperty: 'name',
> +});
> +
> +Ext.define('proxmox-acme-challenges', {
> + extend: 'Ext.data.Model',
> + fields: ['id', 'type', 'schema'],
> + proxy: {
> + type: 'proxmox',
> + //url: "/api2/json/cluster/acme/challenge-schema",
same
> + },
> + idProperty: 'id',
> +});
> +
> +
> +Ext.define('proxmox-acme-plugins', {
> + extend: 'Ext.data.Model',
> + fields: ['type', 'plugin', 'api'],
> + proxy: {
> + type: 'proxmox',
> + //url: "/api2/json/cluster/acme/plugins",
same
maybe we could have /config/acme also for pbs, then we could
add that here and overwrite it in pve?
> + },
> + idProperty: 'plugin',
> +});
> diff --git a/src/data/model/Certificates.js b/src/data/model/Certificates.js
> new file mode 100644
> index 0000000..f3e2a7f
> --- /dev/null
> +++ b/src/data/model/Certificates.js
> @@ -0,0 +1,6 @@
> +Ext.define('proxmox-certificate', {
> + extend: 'Ext.data.Model',
> +
> + fields: ['filename', 'fingerprint', 'issuer', 'notafter', 'notbefore', 'subject', 'san', 'public-key-bits', 'public-key-type'],
> + idProperty: 'filename',
> +});
>
next prev parent reply other threads:[~2021-03-11 12:41 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 14:13 [pmg-devel] [RFC api/gui/wtk/acme 0/many] Certificates & ACME Wolfgang Bumiller
2021-03-09 14:13 ` [pmg-devel] [PATCH api 1/8] depend on libpmg-rs-perl and proxmox-acme Wolfgang Bumiller
2021-03-09 14:13 ` [pmg-devel] [PATCH api 2/8] add PMG::CertHelpers module Wolfgang Bumiller
2021-03-11 10:05 ` Dominik Csapak
2021-03-12 13:55 ` Wolfgang Bumiller
2021-03-09 14:13 ` [pmg-devel] [PATCH api 3/8] add PMG::NodeConfig module Wolfgang Bumiller
2021-03-09 14:13 ` [pmg-devel] [PATCH api 4/8] cluster: sync acme/ and acme-plugins.conf Wolfgang Bumiller
2021-03-09 14:13 ` [pmg-devel] [PATCH api 5/8] api: add ACME and ACMEPlugin module Wolfgang Bumiller
2021-03-11 10:41 ` Dominik Csapak
2021-03-12 14:10 ` Wolfgang Bumiller
2021-03-09 14:13 ` [pmg-devel] [PATCH api 6/8] add certificates api endpoint Wolfgang Bumiller
2021-03-11 11:06 ` Dominik Csapak
2021-03-12 14:51 ` Wolfgang Bumiller
2021-03-09 14:13 ` [pmg-devel] [PATCH api 7/8] add node-config api entry points Wolfgang Bumiller
2021-03-09 14:13 ` [pmg-devel] [PATCH api 8/8] add acme and cert subcommands to pmgconfig Wolfgang Bumiller
2021-03-09 14:13 ` [pmg-devel] [PATCH gui] add certificates and acme view Wolfgang Bumiller
2021-03-11 12:35 ` Dominik Csapak
2021-03-09 14:13 ` [pmg-devel] [PATCH acme] add missing 'use PVE::Acme' statement Wolfgang Bumiller
2021-03-12 15:00 ` [pmg-devel] applied: " Thomas Lamprecht
2021-03-09 14:13 ` [pmg-devel] [PATCH widget-toolkit 1/7] Utils: add ACME related utilities Wolfgang Bumiller
2021-03-09 14:13 ` [pmg-devel] [PATCH widget-toolkit 2/7] add ACME related data models Wolfgang Bumiller
2021-03-11 12:41 ` Dominik Csapak [this message]
2021-03-09 14:13 ` [pmg-devel] [PATCH widget-toolkit 3/7] add ACME forms: Wolfgang Bumiller
2021-03-09 14:13 ` [pmg-devel] [PATCH widget-toolkit 4/7] add certificate panel Wolfgang Bumiller
2021-03-09 14:13 ` [pmg-devel] [PATCH widget-toolkit 5/7] add ACME account panel Wolfgang Bumiller
2021-03-11 13:51 ` Dominik Csapak
2021-03-11 15:14 ` Thomas Lamprecht
2021-03-11 15:16 ` Dominik Csapak
2021-03-11 15:27 ` Thomas Lamprecht
2021-03-09 14:14 ` [pmg-devel] [PATCH widget-toolkit 6/7] add ACME plugin editing Wolfgang Bumiller
2021-03-09 14:14 ` [pmg-devel] [PATCH widget-toolkit 7/7] add ACME domain editing Wolfgang Bumiller
2021-03-10 12:27 ` [pmg-devel] [RFC api/gui/wtk/acme 0/many] Certificates & ACME Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1be6fc5-afa9-7a30-ce37-00dcbf93867f@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox