Re: [pmg-devel] [PATCH widget-toolkit 2/7] add ACME related data models

[Dominik Csapak <d.csapak@proxmox.com>]

comments inline

On 3/9/21 3:13 PM, Wolfgang Bumiller wrote:
> Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
> ---
>   src/Makefile                   |  2 ++
>   src/data/model/ACME.js         | 30 ++++++++++++++++++++++++++++++
>   src/data/model/Certificates.js |  6 ++++++
>   3 files changed, 38 insertions(+)
>   create mode 100644 src/data/model/ACME.js
>   create mode 100644 src/data/model/Certificates.js
> 
> diff --git a/src/Makefile b/src/Makefile
> index 46b90ae..3861bfc 100644
> --- a/src/Makefile
> +++ b/src/Makefile
> @@ -15,6 +15,8 @@ JSSRC=					\
>   	data/RRDStore.js		\
>   	data/TimezoneStore.js		\
>   	data/model/Realm.js		\
> +	data/model/Certificates.js	\
> +	data/model/ACME.js		\
>   	form/DisplayEdit.js		\
>   	form/ExpireDate.js		\
>   	form/IntegerField.js		\
> diff --git a/src/data/model/ACME.js b/src/data/model/ACME.js
> new file mode 100644
> index 0000000..c05572e
> --- /dev/null
> +++ b/src/data/model/ACME.js
> @@ -0,0 +1,30 @@
> +Ext.define('proxmox-acme-accounts', {
> +    extend: 'Ext.data.Model',
> +    fields: ['name'],
> +    proxy: {
> +	type: 'proxmox',
> +	//url: "/api2/json/cluster/acme/account",

i'd prefer not to have the commented out api paths here

> +    },
> +    idProperty: 'name',
> +});
> +
> +Ext.define('proxmox-acme-challenges', {
> +    extend: 'Ext.data.Model',
> +    fields: ['id', 'type', 'schema'],
> +    proxy: {
> +	type: 'proxmox',
> +        //url: "/api2/json/cluster/acme/challenge-schema",

same

> +    },
> +    idProperty: 'id',
> +});
> +
> +
> +Ext.define('proxmox-acme-plugins', {
> +    extend: 'Ext.data.Model',
> +    fields: ['type', 'plugin', 'api'],
> +    proxy: {
> +	type: 'proxmox',
> +	//url: "/api2/json/cluster/acme/plugins",

same


maybe we could have /config/acme also for pbs, then we could
add that here and overwrite it in pve?

> +    },
> +    idProperty: 'plugin',
> +});
> diff --git a/src/data/model/Certificates.js b/src/data/model/Certificates.js
> new file mode 100644
> index 0000000..f3e2a7f
> --- /dev/null
> +++ b/src/data/model/Certificates.js
> @@ -0,0 +1,6 @@
> +Ext.define('proxmox-certificate', {
> +    extend: 'Ext.data.Model',
> +
> +    fields: ['filename', 'fingerprint', 'issuer', 'notafter', 'notbefore', 'subject', 'san', 'public-key-bits', 'public-key-type'],
> +    idProperty: 'filename',
> +});
>