* [pmg-devel] [PATCH spamassassin/pmg-api] add trigger to reload pmg-api services on spamassassin updates
@ 2024-06-12 17:10 Stoiko Ivanov
2024-06-12 17:10 ` [pmg-devel] [PATCH pmg-api 1/1] d/triggers: add interest in " Stoiko Ivanov
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Stoiko Ivanov @ 2024-06-12 17:10 UTC (permalink / raw)
To: pmg-devel
While running some internal tests with the recently released SpamAssassin
4.0.1 I noticed that pmg-smtp-filter did not get restarted upon upgrading
the package.
This has not really been noticed until now, as we ship new
proxmox-spamassassin versions mostly with our point-releases, which do
contain updated versions of pmg-api anyways.
Tested minimally by building both packages with the patches, installing an
updated pmg-api and afterwards installing the updated
proxmox-spamassassin, while verifying that the services indeed get
restarted on my test-machine.
proxmox-spamassassin:
Stoiko Ivanov (1):
d/triggers: add trigger to restart pmg services
debian/triggers | 1 +
1 file changed, 1 insertion(+)
create mode 100644 debian/triggers
pmg-api:
Stoiko Ivanov (1):
d/triggers: add interest in spamassassin updates
debian/triggers | 1 +
1 file changed, 1 insertion(+)
--
2.39.2
_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* [pmg-devel] [PATCH pmg-api 1/1] d/triggers: add interest in spamassassin updates
2024-06-12 17:10 [pmg-devel] [PATCH spamassassin/pmg-api] add trigger to reload pmg-api services on spamassassin updates Stoiko Ivanov
@ 2024-06-12 17:10 ` Stoiko Ivanov
2024-06-12 17:10 ` [pmg-devel] [PATCH spamassassin 1/1] d/triggers: add trigger to restart pmg services Stoiko Ivanov
2025-02-21 17:38 ` [pmg-devel] applied-series: [PATCH spamassassin/pmg-api] add trigger to reload pmg-api services on spamassassin updates Thomas Lamprecht
2 siblings, 0 replies; 4+ messages in thread
From: Stoiko Ivanov @ 2024-06-12 17:10 UTC (permalink / raw)
To: pmg-devel
currently an update to SpamAssassin does not reload any of the
services.
This patch simply adds interest-noawait on a trigger activated by
proxmox-spamassassin, which in turn reloads all services (as already
done for updates to pve-common, and in PVE on updates on other
packages that affect the API).
Technically it might only be necessary to reload pmg-smtp-filter,
pmgproxy and pmgdaemon, to get the benefits of a new spamassassin
version, but reloading all services seems more robust in the long run.
[0] https://git.dpkg.org/cgit/dpkg/dpkg.git/tree/doc/spec/triggers.txt
[1] https://manpages.debian.org/bookworm/dpkg-dev/deb-triggers.5.en.html
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
debian/triggers | 1 +
1 file changed, 1 insertion(+)
diff --git a/debian/triggers b/debian/triggers
index aabe418..0d01133 100644
--- a/debian/triggers
+++ b/debian/triggers
@@ -1 +1,2 @@
interest-noawait pve-api-updates
+interest-noawait pmg-sa-updates
--
2.39.2
_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* [pmg-devel] [PATCH spamassassin 1/1] d/triggers: add trigger to restart pmg services
2024-06-12 17:10 [pmg-devel] [PATCH spamassassin/pmg-api] add trigger to reload pmg-api services on spamassassin updates Stoiko Ivanov
2024-06-12 17:10 ` [pmg-devel] [PATCH pmg-api 1/1] d/triggers: add interest in " Stoiko Ivanov
@ 2024-06-12 17:10 ` Stoiko Ivanov
2025-02-21 17:38 ` [pmg-devel] applied-series: [PATCH spamassassin/pmg-api] add trigger to reload pmg-api services on spamassassin updates Thomas Lamprecht
2 siblings, 0 replies; 4+ messages in thread
From: Stoiko Ivanov @ 2024-06-12 17:10 UTC (permalink / raw)
To: pmg-devel
currently an update to SpamAssassin does not reload the relevant
services in pmg (mostly pmg-smtp-filter and the api-daemons, but
through transitive use statements most others also pull in some
part of SpamAssassin)
This patch simply adds a new trigger [0,1] to reload all services,
as is already done for updates of pve-common).
[0] https://git.dpkg.org/cgit/dpkg/dpkg.git/tree/doc/spec/triggers.txt
[1] https://manpages.debian.org/bookworm/dpkg-dev/deb-triggers.5.en.html
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
debian/triggers | 1 +
1 file changed, 1 insertion(+)
create mode 100644 debian/triggers
diff --git a/debian/triggers b/debian/triggers
new file mode 100644
index 0000000..bd449c4
--- /dev/null
+++ b/debian/triggers
@@ -0,0 +1 @@
+activate-noawait pmg-sa-updates
--
2.39.2
_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* [pmg-devel] applied-series: [PATCH spamassassin/pmg-api] add trigger to reload pmg-api services on spamassassin updates
2024-06-12 17:10 [pmg-devel] [PATCH spamassassin/pmg-api] add trigger to reload pmg-api services on spamassassin updates Stoiko Ivanov
2024-06-12 17:10 ` [pmg-devel] [PATCH pmg-api 1/1] d/triggers: add interest in " Stoiko Ivanov
2024-06-12 17:10 ` [pmg-devel] [PATCH spamassassin 1/1] d/triggers: add trigger to restart pmg services Stoiko Ivanov
@ 2025-02-21 17:38 ` Thomas Lamprecht
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Lamprecht @ 2025-02-21 17:38 UTC (permalink / raw)
To: Stoiko Ivanov, pmg-devel
Am 12.06.24 um 19:10 schrieb Stoiko Ivanov:
> While running some internal tests with the recently released SpamAssassin
> 4.0.1 I noticed that pmg-smtp-filter did not get restarted upon upgrading
> the package.
> This has not really been noticed until now, as we ship new
> proxmox-spamassassin versions mostly with our point-releases, which do
> contain updated versions of pmg-api anyways.
>
> Tested minimally by building both packages with the patches, installing an
> updated pmg-api and afterwards installing the updated
> proxmox-spamassassin, while verifying that the services indeed get
> restarted on my test-machine.
>
> proxmox-spamassassin:
> Stoiko Ivanov (1):
> d/triggers: add trigger to restart pmg services
>
> debian/triggers | 1 +
> 1 file changed, 1 insertion(+)
> create mode 100644 debian/triggers
>
> pmg-api:
> Stoiko Ivanov (1):
> d/triggers: add interest in spamassassin updates
>
> debian/triggers | 1 +
> 1 file changed, 1 insertion(+)
>
applied series, thanks!
_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-02-21 17:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-06-12 17:10 [pmg-devel] [PATCH spamassassin/pmg-api] add trigger to reload pmg-api services on spamassassin updates Stoiko Ivanov
2024-06-12 17:10 ` [pmg-devel] [PATCH pmg-api 1/1] d/triggers: add interest in " Stoiko Ivanov
2024-06-12 17:10 ` [pmg-devel] [PATCH spamassassin 1/1] d/triggers: add trigger to restart pmg services Stoiko Ivanov
2025-02-21 17:38 ` [pmg-devel] applied-series: [PATCH spamassassin/pmg-api] add trigger to reload pmg-api services on spamassassin updates Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal