Re: [pmg-devel] [PATCH pmg-api] acme: allow wildcard domain entries

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

On 12.04.21 15:23, Stoiko Ivanov wrote:
> Reported in our community forum [0], support for wildcard certificates
> via ACME sounds like a good enhancement (especially for PMG).
> 
> In order for this to work you need to configure both:
> * the wild-card subentry (*.domain.example)
> * the base entry (domain.example)

why the base one though?

Any how, would def. warrant a patch to the docs, else this is a bit obscure.

> as ACME domains (and be able to verify both of them via DNS Plugin)
> 
> Quickly tested with a domain of mine (and the powerdns plugin)
> 
> [0]
> https://forum.proxmox.com/threads/feature-request-add-wildcard-support-for-acme.87495/
> 
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
>  src/PMG/CertHelpers.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/PMG/CertHelpers.pm b/src/PMG/CertHelpers.pm
> index 5122f71..b7e79b7 100644
> --- a/src/PMG/CertHelpers.pm
> +++ b/src/PMG/CertHelpers.pm
> @@ -57,7 +57,7 @@ PVE::JSONSchema::register_format('pmg-acme-domain', sub {
>  
>      my $label = qr/[a-z0-9][a-z0-9_-]*/i;
>  
> -    return $domain if $domain =~ /^$label(?:\.$label)+$/;
> +    return $domain if $domain =~ /^(?:\*\.)?$label(?:\.$label)+$/;
>      return undef if $noerr;
>      die "value '$domain' does not look like a valid domain name!\n";
>  });
>