public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Stoiko Ivanov <s.ivanov@proxmox.com>, pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [PATCH pmg-api] acme: allow wildcard domain entries
Date: Mon, 12 Apr 2021 15:45:33 +0200	[thread overview]
Message-ID: <bceb3499-e9c4-f525-4f30-11959b591378@proxmox.com> (raw)
In-Reply-To: <20210412132359.30151-1-s.ivanov@proxmox.com>

On 12.04.21 15:23, Stoiko Ivanov wrote:
> Reported in our community forum [0], support for wildcard certificates
> via ACME sounds like a good enhancement (especially for PMG).
> 
> In order for this to work you need to configure both:
> * the wild-card subentry (*.domain.example)
> * the base entry (domain.example)

why the base one though?

Any how, would def. warrant a patch to the docs, else this is a bit obscure.

> as ACME domains (and be able to verify both of them via DNS Plugin)
> 
> Quickly tested with a domain of mine (and the powerdns plugin)
> 
> [0]
> https://forum.proxmox.com/threads/feature-request-add-wildcard-support-for-acme.87495/
> 
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
>  src/PMG/CertHelpers.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/PMG/CertHelpers.pm b/src/PMG/CertHelpers.pm
> index 5122f71..b7e79b7 100644
> --- a/src/PMG/CertHelpers.pm
> +++ b/src/PMG/CertHelpers.pm
> @@ -57,7 +57,7 @@ PVE::JSONSchema::register_format('pmg-acme-domain', sub {
>  
>      my $label = qr/[a-z0-9][a-z0-9_-]*/i;
>  
> -    return $domain if $domain =~ /^$label(?:\.$label)+$/;
> +    return $domain if $domain =~ /^(?:\*\.)?$label(?:\.$label)+$/;
>      return undef if $noerr;
>      die "value '$domain' does not look like a valid domain name!\n";
>  });
> 





      reply	other threads:[~2021-04-12 13:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-12 13:23 Stoiko Ivanov
2021-04-12 13:45 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bceb3499-e9c4-f525-4f30-11959b591378@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    --cc=s.ivanov@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal