From: Fiona Ebner <f.ebner@proxmox.com>
To: pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [PATCH pmg-api v2] backup: restore: keep directories in /etc/pmg for inotify
Date: Mon, 5 Dec 2022 10:51:46 +0100 [thread overview]
Message-ID: <b6a17486-7a6f-3b67-725f-13fc8bc74ee7@proxmox.com> (raw)
In-Reply-To: <20221130170727.85325-1-s.ivanov@proxmox.com>
Am 30.11.22 um 18:07 schrieb Stoiko Ivanov:
> By wiping the subdirectories in /etc/pmg/, we lose the inotify
> watchers upon restore (/etc/pmg itself and thus most configs are
> currently handled by the keep_root flag to rmtree)
> This can lead to inconsistencies after restoring for parts relying on
> config in a subdirectory (e.g. /etc/pmg/pbs/pbs.conf).
>
> This patch uses File::Find (included in perl-modules-$perlver) to keep
> all directories an unlink everything else.
> This was chosen for future robustness over keeping an explicit list of
> directories to keep, in case a new directory gets added.
>
> quickly tested with a fifo, chardev, and socket in the directory.
>
> an alternative approach would be to simply reload pmgdaemon/pmgproxy
> upon config-restore, but that feels more likely to miss some
> (potentially future) service, expecting inotify to work.
>
> Reported-by: Fiona Ebner <f.ebner@proxmox.com>
Tested-by: Fiona Ebner <f.ebner@proxmox.com>
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
next prev parent reply other threads:[~2022-12-05 9:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 17:07 Stoiko Ivanov
2022-12-05 9:51 ` Fiona Ebner [this message]
2022-12-12 12:18 ` [pmg-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6a17486-7a6f-3b67-725f-13fc8bc74ee7@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox