Re: [pmg-devel] [RFC PATCH pmg-api/gui] add 'view images' checkbox to quarantine view

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 13/02/2024 um 12:30 schrieb Dominik Csapak:
> so that the user can control if images should be loaded, even
> if the admin set that to true in the backend.
> 
> I'm not completely happy with the approach, since there is currently no
> general way for us to see if the backend option was set, unless we'd
> either weaken the permissions necesary to read the config or introduce
> another api call that returns that info, both of which aren't optimal
> imho.
> 
> Also we always show that checkbox now, since i didn't find a way to
> detect if there are images in the mail or not unless we actually load it
> with view images on and try to parse the email again in the frontend.
> Which also sound not really clean.
> 
> For both reasons, sent as RFC.


Maybe s/view/load/ but no hard feelings for that..

Otherwise it seems OK for the current API capabilities.

One thought I had is if it might be worth it to place those view options
(this and dark-filter) inside a dropdown menu button, but fine as is too.