public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>, pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [RFC PATCH pmg-api/gui] add 'view images' checkbox to quarantine view
Date: Wed, 21 Feb 2024 19:51:06 +0100	[thread overview]
Message-ID: <b4b42a2b-d677-4946-aeac-f3f22c76ddd3@proxmox.com> (raw)
In-Reply-To: <20240213113050.2349660-1-d.csapak@proxmox.com>

Am 13/02/2024 um 12:30 schrieb Dominik Csapak:
> so that the user can control if images should be loaded, even
> if the admin set that to true in the backend.
> 
> I'm not completely happy with the approach, since there is currently no
> general way for us to see if the backend option was set, unless we'd
> either weaken the permissions necesary to read the config or introduce
> another api call that returns that info, both of which aren't optimal
> imho.
> 
> Also we always show that checkbox now, since i didn't find a way to
> detect if there are images in the mail or not unless we actually load it
> with view images on and try to parse the email again in the frontend.
> Which also sound not really clean.
> 
> For both reasons, sent as RFC.


Maybe s/view/load/ but no hard feelings for that..

Otherwise it seems OK for the current API capabilities.

One thought I had is if it might be worth it to place those view options
(this and dark-filter) inside a dropdown menu button, but fine as is too.




      parent reply	other threads:[~2024-02-21 18:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-13 11:30 Dominik Csapak
2024-02-13 11:30 ` [pmg-devel] [RFC PATCH pmg-api 1/1] api: quarantine: allow disabling images for content Dominik Csapak
2024-02-21 14:12   ` Mira Limbeck
2024-02-13 11:30 ` [pmg-devel] [RFC PATCH pmg-gui 1/1] quarantine content: add checkbox for controlling image loading Dominik Csapak
2024-02-21 14:17   ` Mira Limbeck
2024-02-21 18:51 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4b42a2b-d677-4946-aeac-f3f22c76ddd3@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal