public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pmg-devel] [PATCH] system options: fix eslint error
@ 2025-02-26 12:45 Gabriel Goller
  2025-02-26 12:56 ` Thomas Lamprecht
  0 siblings, 1 reply; 4+ messages in thread
From: Gabriel Goller @ 2025-02-26 12:45 UTC (permalink / raw)
  To: pmg-devel

Linter error "line too long".

Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
---
 js/SystemOptions.js | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/js/SystemOptions.js b/js/SystemOptions.js
index cc098ceac907..7a933cd0ec26 100644
--- a/js/SystemOptions.js
+++ b/js/SystemOptions.js
@@ -76,7 +76,11 @@ Ext.define('PMG.SystemOptions', {
 			{ deleteEmpty: true, defaultValue: Proxmox.Utils.noneText });
 
 	me.add_text_row('admin-mail-from', gettext("'From:' for Admin Mail"),
-			{ deleteEmpty: true, defaultValue: Proxmox.Utils.noneText, renderer: Ext.htmlEncode });
+			{
+			    deleteEmpty: true,
+			    defaultValue: Proxmox.Utils.noneText,
+			    renderer: Ext.htmlEncode,
+			});
 
 	me.add_proxy_row('http_proxy', gettext("HTTP proxy"));
 
-- 
2.39.5



_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [pmg-devel] [PATCH] system options: fix eslint error
  2025-02-26 12:45 [pmg-devel] [PATCH] system options: fix eslint error Gabriel Goller
@ 2025-02-26 12:56 ` Thomas Lamprecht
  2025-02-26 12:57   ` Gabriel Goller
  0 siblings, 1 reply; 4+ messages in thread
From: Thomas Lamprecht @ 2025-02-26 12:56 UTC (permalink / raw)
  To: Gabriel Goller, pmg-devel

Am 26.02.25 um 13:45 schrieb Gabriel Goller:
> Linter error "line too long".
> 
> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> ---
>  js/SystemOptions.js | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/js/SystemOptions.js b/js/SystemOptions.js
> index cc098ceac907..7a933cd0ec26 100644
> --- a/js/SystemOptions.js
> +++ b/js/SystemOptions.js
> @@ -76,7 +76,11 @@ Ext.define('PMG.SystemOptions', {
>  			{ deleteEmpty: true, defaultValue: Proxmox.Utils.noneText });
>  
>  	me.add_text_row('admin-mail-from', gettext("'From:' for Admin Mail"),
> -			{ deleteEmpty: true, defaultValue: Proxmox.Utils.noneText, renderer: Ext.htmlEncode });
> +			{
> +			    deleteEmpty: true,
> +			    defaultValue: Proxmox.Utils.noneText,
> +			    renderer: Ext.htmlEncode,
> +			});
>  
>  	me.add_proxy_row('http_proxy', gettext("HTTP proxy"));
>  

FYI, this patch is obsolete as 0012b5d ("fix indentation and code style
for various Options grid") was pushed a bit over two hours ago.


_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [pmg-devel] [PATCH] system options: fix eslint error
  2025-02-26 12:56 ` Thomas Lamprecht
@ 2025-02-26 12:57   ` Gabriel Goller
  2025-02-26 13:05     ` Thomas Lamprecht
  0 siblings, 1 reply; 4+ messages in thread
From: Gabriel Goller @ 2025-02-26 12:57 UTC (permalink / raw)
  To: Thomas Lamprecht; +Cc: pmg-devel

>FYI, this patch is obsolete as 0012b5d ("fix indentation and code style
>for various Options grid") was pushed a bit over two hours ago.

Oops, didn't see that one, sorry about that.


_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [pmg-devel] [PATCH] system options: fix eslint error
  2025-02-26 12:57   ` Gabriel Goller
@ 2025-02-26 13:05     ` Thomas Lamprecht
  0 siblings, 0 replies; 4+ messages in thread
From: Thomas Lamprecht @ 2025-02-26 13:05 UTC (permalink / raw)
  To: pmg-devel

Am 26.02.25 um 13:57 schrieb Gabriel Goller:
>> FYI, this patch is obsolete as 0012b5d ("fix indentation and code style
>> for various Options grid") was pushed a bit over two hours ago.
> 
> Oops, didn't see that one, sorry about that.

Yeah, absolutely no worries here, I rather have people send a patch
too much than having none at all.



_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-02-26 13:05 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-02-26 12:45 [pmg-devel] [PATCH] system options: fix eslint error Gabriel Goller
2025-02-26 12:56 ` Thomas Lamprecht
2025-02-26 12:57   ` Gabriel Goller
2025-02-26 13:05     ` Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal