public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: Mira Limbeck <m.limbeck@proxmox.com>, pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [PATCH log-tracker 1/2] add clamd signature found messages to log output
Date: Fri, 4 Aug 2023 14:09:32 +0200	[thread overview]
Message-ID: <b0c7d8e1-ff72-481f-9786-89c6f4d4ce2f@proxmox.com> (raw)
In-Reply-To: <20230719151352.1438974-1-m.limbeck@proxmox.com>

hi,

in general it works and does what is says,
but after looking at the log tracker output, i'm nto sure if it's worth
it. we log the same info directly after that from the pmg-smtp-filter...

otoh, the code is not that big and probably doesn't hurt either

@stoiko, maybe you have some input on that?

in any case, consider both patches

Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Dominik Csapak <d.csapak@proxmox.com>






  parent reply	other threads:[~2023-08-04 12:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-19 15:13 Mira Limbeck
2023-07-19 15:13 ` [pmg-devel] [PATCH log-tracker 2/2] tests: add clamd signature found log test Mira Limbeck
2023-08-04 12:09 ` Dominik Csapak [this message]
2023-09-12 14:18   ` [pmg-devel] [PATCH log-tracker 1/2] add clamd signature found messages to log output Stoiko Ivanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b0c7d8e1-ff72-481f-9786-89c6f4d4ce2f@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=m.limbeck@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal