[pmg-devel] [PATCH pmg-api/gui] perparations and breaking changes

[pmg-devel] [PATCH pmg-api/gui] perparations and breaking changes

[Dominik Csapak]

in bookworm, postgres15 has more restrictive permissions, so we have to
adapt to that

in addition, we want to disable some options by default, namely:
advfiler (advances statistic filters)
use_bayes
use_awl (auto-whitelist)

these patches simply change default in the config & frontent, so these
are breaking changes. To deal with that we have (at least) these three
possibilities:
* simply document them in the upgrade guide
  easiest for us, but has *some* potential for issues when users
  don't properly read/follow them and their bayes/awl db get's deleted
* use preinst/postinst script to set the old defaults as explicit values
  in the config. this shouldn't be too hard, but is some baggage
  that we have to keep until the next major version
* introduce a pmg7to8 tool like for pve
  it's the most work, but we could potentiall use this also for
  detecting misconfigurations, add warnings e.g. about templates, not
  running postgres instances (or still running old instances after the
  upgrade), not current packages, etc.

pmg-api:

Dominik Csapak (3):
  dbtools: grant permissions public schema for created databases
  config: disable awl and bayes by default
  config: disable advanced statistic filters by default

 src/PMG/Config.pm  | 6 +++---
 src/PMG/DBTools.pm | 8 ++++++++
 2 files changed, 11 insertions(+), 3 deletions(-)

pmg-gui:

Dominik Csapak (2):
  configuration: options: adapt to new advanced statistic filter default
  spam: options: adapt do new defaults for bayes/awl

 js/SpamDetectorOptions.js | 4 ++--
 js/SystemOptions.js       | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

-- 
2.30.2

[pmg-devel] [PATCH pmg-api 1/3] dbtools: grant permissions public schema for created databases

[Dominik Csapak]

since postgres 15, the public schema is not world writeable anymore for
security reasons. In our environment, where the db is not externaly
reachable and no database users should exists except the ones we create,
we can safely give the permissions again to be able to use
the root/www-data user without modification of the remaining
code/privileges for postgres.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 src/PMG/DBTools.pm | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/src/PMG/DBTools.pm b/src/PMG/DBTools.pm
index 0b37361..f8eb054 100644
--- a/src/PMG/DBTools.pm
+++ b/src/PMG/DBTools.pm
@@ -344,6 +344,14 @@ my $createdb = sub {
 	'--lc-ctype=C',
 	$dbname,
     );
+
+    # allow root and www-data to access the public SCHEMA like pre prostgres15
+    # this is not a security issue, since the db is not externally reachable anyway and no
+    # other users should exist
+    my $cmd = "GRANT CREATE ON SCHEMA public To \"root\";"
+	."GRANT USAGE ON SCHEMA public To \"root\";"
+	."GRANT CREATE ON SCHEMA public To \"www-data\";"
+	."GRANT USAGE ON SCHEMA public To \"www-data\";";
 };
 
 sub create_ruledb {
-- 
2.30.2

Re: [pmg-devel] [PATCH pmg-api 1/3] dbtools: grant permissions public schema for created databases

[Stoiko Ivanov]

Thanks for the patch!

On Fri, 23 Jun 2023 14:21:00 +0200
Dominik Csapak <d.csapak@proxmox.com> wrote:

> since postgres 15, the public schema is not world writeable anymore for
> security reasons. In our environment, where the db is not externaly
> reachable and no database users should exists except the ones we create,
> we can safely give the permissions again to be able to use
> the root/www-data user without modification of the remaining
> code/privileges for postgres.
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  src/PMG/DBTools.pm | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/src/PMG/DBTools.pm b/src/PMG/DBTools.pm
> index 0b37361..f8eb054 100644
> --- a/src/PMG/DBTools.pm
> +++ b/src/PMG/DBTools.pm
> @@ -344,6 +344,14 @@ my $createdb = sub {
>  	'--lc-ctype=C',
>  	$dbname,
>      );
> +
> +    # allow root and www-data to access the public SCHEMA like pre prostgres15
> +    # this is not a security issue, since the db is not externally reachable anyway and no
> +    # other users should exist
> +    my $cmd = "GRANT CREATE ON SCHEMA public To \"root\";"
> +	."GRANT USAGE ON SCHEMA public To \"root\";"
> +	."GRANT CREATE ON SCHEMA public To \"www-data\";"
> +	."GRANT USAGE ON SCHEMA public To \"www-data\";";
>  };

the command is placed in a variable, but never actually called?
looking through DBTools - it might be a better fit to declare
a sub create_user, and put the `createuser` invocation as well as the
GRANT sql commands there - but the separate sub is only a suggestion.


>  
>  sub create_ruledb {

[pmg-devel] [PATCH pmg-api 2/3] config: disable awl and bayes by default

[Dominik Csapak]

Since most often they don't help in a default setup without manually
training with many examples.

Note that this is a breaking change, and a config rewrite will
trigger a deletion of bayes and awl databases.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 src/PMG/Config.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/PMG/Config.pm b/src/PMG/Config.pm
index 20afd71..dc28c02 100755
--- a/src/PMG/Config.pm
+++ b/src/PMG/Config.pm
@@ -177,12 +177,12 @@ sub properties {
 	use_bayes => {
 	    description => "Whether to use the naive-Bayesian-style classifier.",
 	    type => 'boolean',
-	    default => 1,
+	    default => 0,
 	},
 	use_awl => {
 	    description => "Use the Auto-Whitelist plugin.",
 	    type => 'boolean',
-	    default => 1,
+	    default => 0,
 	},
 	use_razor => {
 	    description => "Whether to use Razor2, if it is available.",
-- 
2.30.2

[pmg-devel] applied: [PATCH pmg-api 2/3] config: disable awl and bayes by default

[Thomas Lamprecht]

Am 23/06/2023 um 14:21 schrieb Dominik Csapak:
> Since most often they don't help in a default setup without manually
> training with many examples.
> 
> Note that this is a breaking change, and a config rewrite will
> trigger a deletion of bayes and awl databases.
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  src/PMG/Config.pm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
>

applied, thanks!

[pmg-devel] [PATCH pmg-api 3/3] config: disable advanced statistic filters by default

[Dominik Csapak]

If the (documented) behaviour is not known, it is rather unexpected and
confusing. So disable by default.

Note that this is a breaking change, since enabling them is just a
config switch, it shouldn't be much of a problem.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 src/PMG/Config.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PMG/Config.pm b/src/PMG/Config.pm
index dc28c02..fe89e11 100755
--- a/src/PMG/Config.pm
+++ b/src/PMG/Config.pm
@@ -72,7 +72,7 @@ If this is enabled, the receiver statistic are limited to active ones
 statistic will not contain these active receivers.
 EODESC
 	    type => 'boolean',
-	    default => 1,
+	    default => 0,
 	},
 	dailyreport => {
 	    description => "Send daily reports.",
-- 
2.30.2

[pmg-devel] applied: [PATCH pmg-api 3/3] config: disable advanced statistic filters by default

[Thomas Lamprecht]

Am 23/06/2023 um 14:21 schrieb Dominik Csapak:
> If the (documented) behaviour is not known, it is rather unexpected and
> confusing. So disable by default.
> 
> Note that this is a breaking change, since enabling them is just a
> config switch, it shouldn't be much of a problem.
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  src/PMG/Config.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied, thanks!

[pmg-devel] [PATCH pmg-gui 1/2] configuration: options: adapt to new advanced statistic filter default

[Dominik Csapak]

default in the backend is now false

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 js/SystemOptions.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/js/SystemOptions.js b/js/SystemOptions.js
index 675dde4..7a22e1a 100644
--- a/js/SystemOptions.js
+++ b/js/SystemOptions.js
@@ -67,7 +67,7 @@ Ext.define('PMG.SystemOptions', {
 			   { defaultValue: 1 });
 
 	me.add_boolean_row('advfilter', gettext('Use advanced statistic filters'),
-			   { defaultValue: 1 });
+			   { defaultValue: 0 });
 
 	me.add_integer_row('statlifetime', gettext('User statistic lifetime (days)'),
 			   { minValue: 1, defaultValue: 7, deleteEmpty: true });
-- 
2.30.2

[pmg-devel] applied: [PATCH pmg-gui 1/2] configuration: options: adapt to new advanced statistic filter default

[Thomas Lamprecht]

Am 23/06/2023 um 14:21 schrieb Dominik Csapak:
> default in the backend is now false
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  js/SystemOptions.js | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied, thanks!

[pmg-devel] [PATCH pmg-gui 2/2] spam: options: adapt do new defaults for bayes/awl

[Dominik Csapak]

both options default to false now in the backend

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 js/SpamDetectorOptions.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/js/SpamDetectorOptions.js b/js/SpamDetectorOptions.js
index 58eaee9..ccfff96 100644
--- a/js/SpamDetectorOptions.js
+++ b/js/SpamDetectorOptions.js
@@ -8,10 +8,10 @@ Ext.define('PMG.SpamDetectorOptions', {
 	var me = this;
 
 	me.add_boolean_row('use_awl', gettext('Use auto-whitelists'),
-			   { defaultValue: 1 });
+			   { defaultValue: 0 });
 
 	me.add_boolean_row('use_bayes', gettext('Use Bayesian filter'),
-			   { defaultValue: 1 });
+			   { defaultValue: 0 });
 
 	me.add_boolean_row('rbl_checks', gettext('Use RBL checks'),
 			   { defaultValue: 1 });
-- 
2.30.2

[pmg-devel] applied: [PATCH pmg-gui 2/2] spam: options: adapt do new defaults for bayes/awl

[Thomas Lamprecht]

Am 23/06/2023 um 14:21 schrieb Dominik Csapak:
> both options default to false now in the backend
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  js/SpamDetectorOptions.js | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
>

applied, thanks!