public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Friedrich Weber <f.weber@proxmox.com>
To: Stoiko Ivanov <s.ivanov@proxmox.com>
Cc: pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [PATCH pmg-docs] pmg-mail-filter: clarify matching of Who objects
Date: Thu, 6 Feb 2025 16:54:16 +0100	[thread overview]
Message-ID: <a712ca12-5994-481c-9e65-69b90217bf76@proxmox.com> (raw)
In-Reply-To: <20250206163049.51edfc3f@rosa.proxmox.com>

Thanks for the quick review!

On 06/02/2025 16:30, Stoiko Ivanov wrote:
> [...]
> On Thu,  6 Feb 2025 16:16:20 +0100
> Friedrich Weber <f.weber@proxmox.com> wrote:
> 
>> In particular, explain that Who objects match against Envelope From
>> and Envelope To, not the From: and To: mail headers. This is
>> occasionally a source of confusion in enterprise support.
>>
>> Signed-off-by: Friedrich Weber <f.weber@proxmox.com>
>> ---
>>  pmg-mail-filter.adoc | 10 ++++++++++
>>  1 file changed, 10 insertions(+)
>>
>> diff --git a/pmg-mail-filter.adoc b/pmg-mail-filter.adoc
>> index 235f156..65d28b6 100644
>> --- a/pmg-mail-filter.adoc
>> +++ b/pmg-mail-filter.adoc
>> @@ -265,6 +265,16 @@ We have two important 'Who' objects called 'Blacklist' and
>>  'Whitelist'. These are used in the default ruleset to globally block
>>  or allow specific senders.
>>  
>> +Note that 'Who' objects match against the mail addresses given during the SMTP
>> +dialog:
> maybe also mention that this is the information you see in the
> journal/logs by default?

Makes sense, will add!

>> +
>> +* 'Who' objects in the 'FROM' category match against the mail address given in
>> +  the `MAIL FROM` command (the Envelope From).
>> +* 'Who' objects in the 'TO' category match against the mail address given in
>> +  the `MAIL TO` command (the Envelope To).
> the smtp-verb is RCPT (`RCPT TO`)

Urgh, sorry about that, thanks for spotting it.

Will send a v2.


_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel


  reply	other threads:[~2025-02-06 15:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-06 15:16 Friedrich Weber
2025-02-06 15:30 ` Stoiko Ivanov
2025-02-06 15:54   ` Friedrich Weber [this message]
2025-02-17 11:56     ` Friedrich Weber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a712ca12-5994-481c-9e65-69b90217bf76@proxmox.com \
    --to=f.weber@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    --cc=s.ivanov@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal