public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Stoiko Ivanov <s.ivanov@proxmox.com>, pmg-devel@lists.proxmox.com
Subject: [pmg-devel] applied: [PATCH pmg-api] fix #2013 spamreport: remove ticket if authmode is ldap
Date: Mon, 28 Jun 2021 15:31:27 +0200	[thread overview]
Message-ID: <a65555de-1f37-152b-337d-5729e550bbf5@proxmox.com> (raw)
In-Reply-To: <20210517140257.3449-1-s.ivanov@proxmox.com>

On 17.05.21 16:02, Stoiko Ivanov wrote:
> Currently the 'authmode' setting for the spamquarantine is not used
> anywhere. According to documentation setting it to 'ldap' should allow
> access to the quarantine only with ldap credentials.
> 
> This patch addresses the issue by not generating a quarantineticket,
> and adapting all links accordingly if the authmode is 'ldap'.
> 
> tested by changing the authmode and running
> `pmgqm send -receiver <email-address> -debug 1`
> 
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
>  src/PMG/CLI/pmgqm.pm | 21 ++++++++++++++++-----
>  1 file changed, 16 insertions(+), 5 deletions(-)
> 
>

applied, with Dominiks R-b, T-b tags, thanks!

His comment was left unanswered though, just as a reminder:

> just want to comment that this is now the opposite behaviour
> of pmg <= 4 where setting authmode to ldap would not
> change the template, but not accept quarantine tickets anymore
> (which we should *probably* also do, since there may be
> some valid tickets around; but this can be a separate patch) 

(no hard feelings regarding this from my side, as said, just a reminder
to ensure it did not get lost, or was discussed off-list and the result of
that did not made it to the list or the like)




      parent reply	other threads:[~2021-06-28 13:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-17 14:02 [pmg-devel] " Stoiko Ivanov
2021-06-16 11:10 ` Dominik Csapak
2021-06-28 13:31 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a65555de-1f37-152b-337d-5729e550bbf5@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    --cc=s.ivanov@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal