[pmg-devel] [PATCH pmg-api 1/2] fix #4818: utils: Don't set minLength for username

[pmg-devel] [PATCH pmg-api 1/2] fix #4818: utils: Don't set minLength for username

[Maximiliano Sandoval]

This matches pve-access-control/src/PVE/Auth/Plugin.pm.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 src/PMG/Utils.pm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/PMG/Utils.pm b/src/PMG/Utils.pm
index c19b31f..88dcff7 100644
--- a/src/PMG/Utils.pm
+++ b/src/PMG/Utils.pm
@@ -110,8 +110,7 @@ PVE::JSONSchema::register_standard_option('userid', {
 PVE::JSONSchema::register_standard_option('username', {
     description => "Username (without realm)",
     type => 'string',
-    pattern => '[^\s:\/\@]{3,60}',
-    minLength => 4,
+    pattern => '[^\s:\/\@]{1,60}',
     maxLength => 64,
 });
 
-- 
2.39.2

[pmg-devel] [PATCH pmg-gui 2/2] fix #4818: Revert "UserEdit: add minLength of 4 to username field"

[Maximiliano Sandoval]

So we match pmg-api.

This reverts commit 40ced6648d6b94b32a0a0a957b4c9c7c2927a721.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 js/UserEdit.js | 1 -
 1 file changed, 1 deletion(-)

diff --git a/js/UserEdit.js b/js/UserEdit.js
index e212530..bd94686 100644
--- a/js/UserEdit.js
+++ b/js/UserEdit.js
@@ -38,7 +38,6 @@ Ext.define('PMG.UserEdit', {
 		fieldLabel: gettext('User name'),
 		renderer: Ext.htmlEncode,
 		allowBlank: false,
-		minLength: 4,
 		cbind: {
 		    submitValue: '{isCreate}',
 		    xtype: '{useridXType}',
-- 
2.39.2

Re: [pmg-devel] [PATCH pmg-api 1/2] fix #4818: utils: Don't set minLength for username

[Gabriel Goller]

LGTM!

Consider:
Tested-by: Gabriel Goller <g.goller@proxmox.com>
Reviewed-by: Gabriel Goller <g.goller@proxmox.com>

[pmg-devel] applied-series: [PATCH pmg-api 1/2] fix #4818: utils: Don't set minLength for username

[Stoiko Ivanov]

applied both patches (sadly overlooking Gabriel's testing and review -
sorry) - Thanks!.

If you want to further cleanup that area - aligning the regular expressions
and lengths for 'userid' (<10 lines above your changes) and testing it
might help causing less confusion for further changes in this part of code.


On Tue, Sep 05, 2023 at 02:54:43PM +0200, Maximiliano Sandoval wrote:
> This matches pve-access-control/src/PVE/Auth/Plugin.pm.
> 
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>  src/PMG/Utils.pm | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/src/PMG/Utils.pm b/src/PMG/Utils.pm
> index c19b31f..88dcff7 100644
> --- a/src/PMG/Utils.pm
> +++ b/src/PMG/Utils.pm
> @@ -110,8 +110,7 @@ PVE::JSONSchema::register_standard_option('userid', {
>  PVE::JSONSchema::register_standard_option('username', {
>      description => "Username (without realm)",
>      type => 'string',
> -    pattern => '[^\s:\/\@]{3,60}',
> -    minLength => 4,
> +    pattern => '[^\s:\/\@]{1,60}',
>      maxLength => 64,
>  });
>  
> -- 
> 2.39.2
> 
> 
> 
> _______________________________________________
> pmg-devel mailing list
> pmg-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
> 
> 

Re: [pmg-devel] applied-series: [PATCH pmg-api 1/2] fix #4818: utils: Don't set minLength for username

[Maximiliano Sandoval]

Stoiko Ivanov <s.ivanov@proxmox.com> writes:

> applied both patches (sadly overlooking Gabriel's testing and review -
> sorry) - Thanks!.

Is it possible that the commit 2/2 was not applied?

--
Maximiliano

Re: [pmg-devel] applied-series: [PATCH pmg-api 1/2] fix #4818: utils: Don't set minLength for username

[Maximiliano Sandoval]

My bad, it is there
https://git.proxmox.com/?p=pmg-gui.git;a=commit;h=1e8cfaf39986cf77010fe48c434371ee0bdaffb9.
Please move along.

Maximiliano Sandoval <m.sandoval@proxmox.com> writes:

> Stoiko Ivanov <s.ivanov@proxmox.com> writes:
>
>> applied both patches (sadly overlooking Gabriel's testing and review -
>> sorry) - Thanks!.
>
> Is it possible that the commit 2/2 was not applied?


--
Maximiliano