public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pmg-devel] [PATCH pmg-gui] ui: node summary: use SI units for HD usage
@ 2023-11-21 11:37 Christian Ebner
  2023-12-15 15:29 ` [pmg-devel] applied: " Stoiko Ivanov
  0 siblings, 1 reply; 2+ messages in thread
From: Christian Ebner @ 2023-11-21 11:37 UTC (permalink / raw)
  To: pmg-devel

SI units are used for storage size information, as typically used by
hard disk manufacturers.

Change the root filesystem usage values in the node summary to be
consistent
---
 js/dashboard/NodeInfo.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/js/dashboard/NodeInfo.js b/js/dashboard/NodeInfo.js
index 7952d03..99eb4d3 100644
--- a/js/dashboard/NodeInfo.js
+++ b/js/dashboard/NodeInfo.js
@@ -58,7 +58,7 @@ Ext.define('PMG.NodeInfoPanel', {
 	    title: gettext('HD space') + ' (root)',
 	    valueField: 'rootfs',
 	    maxField: 'rootfs',
-	    renderer: Proxmox.Utils.render_node_size_usage,
+	    renderer: ({ used, total }) => Proxmox.Utils.render_size_usage(used, total, true),
 	},
 	{
 	    iconCls: 'pmx-icon-size fa fa-fw fa-refresh',
-- 
2.39.2





^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pmg-devel] applied: [PATCH pmg-gui] ui: node summary: use SI units for HD usage
  2023-11-21 11:37 [pmg-devel] [PATCH pmg-gui] ui: node summary: use SI units for HD usage Christian Ebner
@ 2023-12-15 15:29 ` Stoiko Ivanov
  0 siblings, 0 replies; 2+ messages in thread
From: Stoiko Ivanov @ 2023-12-15 15:29 UTC (permalink / raw)
  To: Christian Ebner; +Cc: pmg-devel

applied the patch - Thanks!

On Tue, Nov 21, 2023 at 12:37:31PM +0100, Christian Ebner wrote:
> SI units are used for storage size information, as typically used by
> hard disk manufacturers.
> 
> Change the root filesystem usage values in the node summary to be
> consistent
> ---
>  js/dashboard/NodeInfo.js | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/js/dashboard/NodeInfo.js b/js/dashboard/NodeInfo.js
> index 7952d03..99eb4d3 100644
> --- a/js/dashboard/NodeInfo.js
> +++ b/js/dashboard/NodeInfo.js
> @@ -58,7 +58,7 @@ Ext.define('PMG.NodeInfoPanel', {
>  	    title: gettext('HD space') + ' (root)',
>  	    valueField: 'rootfs',
>  	    maxField: 'rootfs',
> -	    renderer: Proxmox.Utils.render_node_size_usage,
> +	    renderer: ({ used, total }) => Proxmox.Utils.render_size_usage(used, total, true),
>  	},
>  	{
>  	    iconCls: 'pmx-icon-size fa fa-fw fa-refresh',
> -- 
> 2.39.2
> 
> 
> 
> _______________________________________________
> pmg-devel mailing list
> pmg-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
> 
> 




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-12-15 15:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-21 11:37 [pmg-devel] [PATCH pmg-gui] ui: node summary: use SI units for HD usage Christian Ebner
2023-12-15 15:29 ` [pmg-devel] applied: " Stoiko Ivanov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal