From: "Stefan Sterz" <s.sterz@proxmox.com>
To: "Thomas Lamprecht" <t.lamprecht@proxmox.com>,
"Dominik Csapak" <d.csapak@proxmox.com>,
<pmg-devel@lists.proxmox.com>
Subject: Re: [pmg-devel] applied: [PATCH pmg-gui] objects: use font-weight for bold text
Date: Thu, 22 Feb 2024 17:36:44 +0100 [thread overview]
Message-ID: <CZBR661VN8YF.2RDHQU7HYMZEV@proxmox.com> (raw)
In-Reply-To: <6a51ea2a-67f7-4fbc-a602-b0aae27c37c5@proxmox.com>
On Thu Feb 22, 2024 at 3:51 PM CET, Thomas Lamprecht wrote:
> Am 22/02/2024 um 15:29 schrieb Dominik Csapak:
> > mdn[0] recommends using `font-weight: bold;` for making the text actually bold
> > While it has the same effect often, it depends on the font and browser
> > if the font is rendered bold in a <b> tag.
> >
> > 0: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/b
> >
> > Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> > ---
> > js/ObjectGroup.js | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> >
>
> applied, thanks!
>
> FWIW, one general option might also be to add CSS setting the font-weight to
> the <b> tag in general, but not sure what would break with that..
>
just to add my two cents to this: generally it would be nice to avoid
inline css imo. maybe we could also add a css class to the element that
has some semantic meaning and use that to style the element. as is
recommendet by mdn:
> It is a good practice to use the class attribute on the <b> element in
> order to convey additional semantic information as needed (for example
> <b class="lead"> for the first sentence in a paragraph).
>
> - [0]
alternatively, we could use the more semanticaly meaninful `<strong>`[1]
element and define that as bold (which is the default, but the
recommendation is to make that explicit there too). this would imply a
"strong importance".
[1]: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/strong
>
> _______________________________________________
> pmg-devel mailing list
> pmg-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
prev parent reply other threads:[~2024-02-22 16:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 14:29 [pmg-devel] " Dominik Csapak
2024-02-22 14:51 ` [pmg-devel] applied: " Thomas Lamprecht
2024-02-22 16:36 ` Stefan Sterz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CZBR661VN8YF.2RDHQU7HYMZEV@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox