From: Mira Limbeck <m.limbeck@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>, pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [PATCH log-tracker 1/3] update tests
Date: Fri, 26 Feb 2021 10:22:24 +0100 [thread overview]
Message-ID: <971b5023-4953-1ef4-2519-2f0069274e37@proxmox.com> (raw)
In-Reply-To: <261ad9c6-a149-f37b-a040-525bf4d37d4e@proxmox.com>
On 2/25/21 11:56 AM, Thomas Lamprecht wrote:
> On 19.02.21 11:31, Mira Limbeck wrote:
>> As we only have month, day and time available but not the year, we have
>> to update the tests every year.
> I'm probably just missing context but why exactly is that the case?
>
The logs only contain month, day and time of the day which we parse. We
do this based on the current date and timezone.
So depending on the current date and the date in the logs, we either
assume it to be in the past or in the future. This results in a
different calculated CTIME then and the tests need to be updated
accordingly.
Stoiko and I talked about this when I sent the patch, and we probably
want to switch to logging the year as well with 7.0 so these test
updates are no longer required afterwards.
next prev parent reply other threads:[~2021-02-26 9:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 10:31 Mira Limbeck
2021-02-19 10:31 ` [pmg-devel] [PATCH log-tracker 2/3] after-queue: fix wrong DStatus if relay is 'removed' before 'lmtp' line Mira Limbeck
2021-02-19 10:31 ` [pmg-devel] [PATCH log-tracker 3/3] add test case for relay removed before lmtp Mira Limbeck
2021-03-22 13:07 ` Mira Limbeck
2021-02-25 10:56 ` [pmg-devel] [PATCH log-tracker 1/3] update tests Thomas Lamprecht
2021-02-26 9:22 ` Mira Limbeck [this message]
2021-02-26 12:52 ` Mira Limbeck
2021-02-26 13:08 ` Thomas Lamprecht
2021-03-15 9:30 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=971b5023-4953-1ef4-2519-2f0069274e37@proxmox.com \
--to=m.limbeck@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox