public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Stoiko Ivanov <s.ivanov@proxmox.com>,
	Christoph Heiss <c.heiss@proxmox.com>
Cc: pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [PATCH pmg-gui] css: fix icon/text alignment in panel headers for Firefox
Date: Wed, 13 Sep 2023 10:05:18 +0200	[thread overview]
Message-ID: <949e53b9-2bc9-4b97-bda7-0107301b23a3@proxmox.com> (raw)
In-Reply-To: <20230912161526.77438010@rosa.proxmox.com>

Am 12/09/2023 um 16:15 schrieb Stoiko Ivanov:
> sorry for replying so late
> 
> * managed to reproduce it in firefox 102.15.0esr (version in bookworm)
> * the patch fixes it for the pmg-gui
> 
> * Regarding your question if a fix is better done in pwt or a separate fix
>   for proxmox-backup would be better I think Dominik or Thomas might have
>   better ideas/suggestions

I think widget-toolkit would be better, because if we're sure about this
fix it should work in any case and for all of our ExtJS based stuff, and
if there's something off we will notice quicker this way and have probably
a better grasp about what to do then.
> in any case - consider this:
> Tested-by: Stoiko Ivanov <s.ivanov@proxmox.com>

You could (temporarily) apply this, or wait for Christoph to send a
widget-toolkit, both are fine for me.




  reply	other threads:[~2023-09-13  8:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-09 10:07 Christoph Heiss
2023-08-09 14:33 ` Christoph Heiss
2023-09-12 14:15   ` Stoiko Ivanov
2023-09-13  8:05     ` Thomas Lamprecht [this message]
2023-09-14  7:00 ` Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=949e53b9-2bc9-4b97-bda7-0107301b23a3@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=c.heiss@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    --cc=s.ivanov@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal