Re: [pmg-devel] [PATCH pmg-api 3/4] partially fix #2077: pmgsh: remove dependency on Term::ReadLine

[Fiona Ebner <f.ebner@proxmox.com>]

Am 18.09.25 um 10:58 PM schrieb Stoiko Ivanov:
> Thanks for tackling this!
> 
> applied the patch for pve-common and played around a bit with pmgsh - and
> yes - I did miss the completion (not the history though.. and am not sure
> if I overlooked some other readline feature that would be lost)
> 
> but this reminded me of pvesh and that we dropped interactive mode at some
> point (around PVE 5.2) there:
> https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=cfc6a662938b90069e6c70b8112021a4554bad27
> and the rationale of using bash for completion (still) sounds sensible.

Oh, that dropped the REPL-style interface completely. If we do want to
go ahead with dropping Term::ReadLine for pmgsh, I think we should do
that here too.

> did not look closer at what pmgsh is still missing from pvesh (the latter
> saw quite a bit more changes in the past years) - but currently this seems
> to be a good alternative.
> (I'm not sure if I'll get to checking this in the upcoming 1-2 weeks, but
> could try if you are busy elsewhere and noone else steps up)

Do you have an example for what (potential) features you have in mind
here? Or just looking through all pvesh changes and see what would be
nice to have for pmgsh too?

> FWIW - tried registering an acme account (patch 1/4) - also worked fine.

Would you mind adding a T-b there :)?


_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel