From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Stoiko Ivanov <s.ivanov@proxmox.com>, pmg-devel@lists.proxmox.com
Subject: [pmg-devel] applied: [PATCH pmg-api 2/5] ruledb: add deprecation warnings for unused actions
Date: Tue, 15 Nov 2022 15:32:46 +0100 [thread overview]
Message-ID: <916175b1-4cdc-0ab2-747a-3be588154aec@proxmox.com> (raw)
In-Reply-To: <20221109182728.629576-3-s.ivanov@proxmox.com>
Am 09/11/2022 um 19:27 schrieb Stoiko Ivanov:
> * ReportSpam
> * Attach
> * Counter
>
> are all still present since (at least) the release of PMG 5.0, but
> were never exposed in the API/GUI.
>
> All of them in their current form don't seem to fit well nowadays, or
> their functionality was taken over by some other Action:
> * Attach - the functionality is currently present in the Notify action
> (attach original mail)
> * Counter - without a matching What object simply increasing a counter
> by one in the database serves no purpose
> * ReportSpam - sending potentially sensitive mail automatically to the
> public SpamAssassin project does not seem to fit well nowadays
>
> Instead of dropping them right away - this patch adds logging when
> they are encountered while loading or when they are run, to keep
> backwards-compatibility for users who have very long-running PMG
> instances (not sure if the actions were ever used in the pre git-days
> of PMG)
>
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> src/PMG/RuleDB.pm | 14 +++++++++++++-
> src/PMG/RuleDB/Attach.pm | 7 +++++++
> src/PMG/RuleDB/Counter.pm | 5 +++++
> src/PMG/RuleDB/ReportSpam.pm | 5 +++++
> 4 files changed, 30 insertions(+), 1 deletion(-)
>
>
applied, thanks!
next prev parent reply other threads:[~2022-11-15 14:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 18:27 [pmg-devel] [PATCH pmg-api 0/5] ruledb - improve experience for non-ascii tests and mails Stoiko Ivanov
2022-11-09 18:27 ` [pmg-devel] [PATCH pmg-api 1/5] ruledb: modfield: properly encode field after variable substitution Stoiko Ivanov
2022-11-11 13:56 ` [pmg-devel] applied: " Thomas Lamprecht
2022-11-09 18:27 ` [pmg-devel] [PATCH pmg-api 2/5] ruledb: add deprecation warnings for unused actions Stoiko Ivanov
2022-11-14 16:02 ` Dominik Csapak
2022-11-15 14:32 ` Thomas Lamprecht [this message]
2022-11-09 18:27 ` [pmg-devel] [PATCH pmg-api 3/5] fix #2541 ruledb: encode relevant values as utf-8 in database Stoiko Ivanov
2022-11-14 14:36 ` Dominik Csapak
2022-11-09 18:27 ` [pmg-devel] [PATCH pmg-api 4/5] ruledb: encode e-mail addresses for syslog Stoiko Ivanov
2022-11-14 14:49 ` Dominik Csapak
2022-11-09 18:27 ` [pmg-devel] [PATCH pmg-api 5/5] partially fix #2465: handle smtputf8 addresses in the rule-system Stoiko Ivanov
2022-11-14 16:03 ` Dominik Csapak
2022-11-14 16:02 ` [pmg-devel] [PATCH pmg-api 0/5] ruledb - improve experience for non-ascii tests and mails Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=916175b1-4cdc-0ab2-747a-3be588154aec@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox