public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pmg-devel] [PATCH pmg-api] fix 4006: do not split from header on ', ' for spamreport mails
@ 2022-11-15  9:28 Stoiko Ivanov
  2022-11-15 14:19 ` Dominik Csapak
  2022-11-15 14:32 ` [pmg-devel] applied: " Thomas Lamprecht
  0 siblings, 2 replies; 3+ messages in thread
From: Stoiko Ivanov @ 2022-11-15  9:28 UTC (permalink / raw)
  To: pmg-devel

This commit follows 0f123331c73bbcb73303f1f07b5318a68c83ad64, which
did the same change for the API calls.

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
 src/PMG/CLI/pmgqm.pm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/PMG/CLI/pmgqm.pm b/src/PMG/CLI/pmgqm.pm
index 1e21bf0..dbec8ef 100755
--- a/src/PMG/CLI/pmgqm.pm
+++ b/src/PMG/CLI/pmgqm.pm
@@ -46,8 +46,7 @@ sub get_item_data {
     $item->{subject} = PMG::Utils::rfc1522_to_html(
 	PVE::Tools::trim($head->get('subject')) || 'No Subject');
 
-    my @fromarray = split('\s*,\s*', $head->get('from') || $ref->{sender});
-    my $from = PMG::Utils::rfc1522_to_html(PVE::Tools::trim($fromarray[0]));
+    my $from = PMG::Utils::rfc1522_to_html(PVE::Tools::trim($head->get('from') // $ref->{sender}));
     my $sender = PMG::Utils::rfc1522_to_html(PVE::Tools::trim($head->get('sender')));
 
     if ($sender) {
-- 
2.30.2





^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [pmg-devel] [PATCH pmg-api] fix 4006: do not split from header on ', ' for spamreport mails
  2022-11-15  9:28 [pmg-devel] [PATCH pmg-api] fix 4006: do not split from header on ', ' for spamreport mails Stoiko Ivanov
@ 2022-11-15 14:19 ` Dominik Csapak
  2022-11-15 14:32 ` [pmg-devel] applied: " Thomas Lamprecht
  1 sibling, 0 replies; 3+ messages in thread
From: Dominik Csapak @ 2022-11-15 14:19 UTC (permalink / raw)
  To: Stoiko Ivanov, pmg-devel

LGTM

Tested-by: Dominik Csapak <d.csapak@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>

On 11/15/22 10:28, Stoiko Ivanov wrote:
> This commit follows 0f123331c73bbcb73303f1f07b5318a68c83ad64, which
> did the same change for the API calls.
> 
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
>   src/PMG/CLI/pmgqm.pm | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/src/PMG/CLI/pmgqm.pm b/src/PMG/CLI/pmgqm.pm
> index 1e21bf0..dbec8ef 100755
> --- a/src/PMG/CLI/pmgqm.pm
> +++ b/src/PMG/CLI/pmgqm.pm
> @@ -46,8 +46,7 @@ sub get_item_data {
>       $item->{subject} = PMG::Utils::rfc1522_to_html(
>   	PVE::Tools::trim($head->get('subject')) || 'No Subject');
>   
> -    my @fromarray = split('\s*,\s*', $head->get('from') || $ref->{sender});
> -    my $from = PMG::Utils::rfc1522_to_html(PVE::Tools::trim($fromarray[0]));
> +    my $from = PMG::Utils::rfc1522_to_html(PVE::Tools::trim($head->get('from') // $ref->{sender}));
>       my $sender = PMG::Utils::rfc1522_to_html(PVE::Tools::trim($head->get('sender')));
>   
>       if ($sender) {





^ permalink raw reply	[flat|nested] 3+ messages in thread

* [pmg-devel] applied: [PATCH pmg-api] fix 4006: do not split from header on ', ' for spamreport mails
  2022-11-15  9:28 [pmg-devel] [PATCH pmg-api] fix 4006: do not split from header on ', ' for spamreport mails Stoiko Ivanov
  2022-11-15 14:19 ` Dominik Csapak
@ 2022-11-15 14:32 ` Thomas Lamprecht
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Lamprecht @ 2022-11-15 14:32 UTC (permalink / raw)
  To: Stoiko Ivanov, pmg-devel

Am 15/11/2022 um 10:28 schrieb Stoiko Ivanov:
> This commit follows 0f123331c73bbcb73303f1f07b5318a68c83ad64, which
> did the same change for the API calls.
> 
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
>  src/PMG/CLI/pmgqm.pm | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
>

applied, with Dominik's T-b & R-b, thanks!




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-11-15 14:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-15  9:28 [pmg-devel] [PATCH pmg-api] fix 4006: do not split from header on ', ' for spamreport mails Stoiko Ivanov
2022-11-15 14:19 ` Dominik Csapak
2022-11-15 14:32 ` [pmg-devel] applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal