From: Dominik Csapak <d.csapak@proxmox.com>
To: Stoiko Ivanov <s.ivanov@proxmox.com>, pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [PATCH pmg-api] fix 4006: do not split from header on ', ' for spamreport mails
Date: Tue, 15 Nov 2022 15:19:19 +0100 [thread overview]
Message-ID: <8df49fde-d500-646e-84c1-7f4b2a330b06@proxmox.com> (raw)
In-Reply-To: <20221115092820.38890-1-s.ivanov@proxmox.com>
LGTM
Tested-by: Dominik Csapak <d.csapak@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
On 11/15/22 10:28, Stoiko Ivanov wrote:
> This commit follows 0f123331c73bbcb73303f1f07b5318a68c83ad64, which
> did the same change for the API calls.
>
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> src/PMG/CLI/pmgqm.pm | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/src/PMG/CLI/pmgqm.pm b/src/PMG/CLI/pmgqm.pm
> index 1e21bf0..dbec8ef 100755
> --- a/src/PMG/CLI/pmgqm.pm
> +++ b/src/PMG/CLI/pmgqm.pm
> @@ -46,8 +46,7 @@ sub get_item_data {
> $item->{subject} = PMG::Utils::rfc1522_to_html(
> PVE::Tools::trim($head->get('subject')) || 'No Subject');
>
> - my @fromarray = split('\s*,\s*', $head->get('from') || $ref->{sender});
> - my $from = PMG::Utils::rfc1522_to_html(PVE::Tools::trim($fromarray[0]));
> + my $from = PMG::Utils::rfc1522_to_html(PVE::Tools::trim($head->get('from') // $ref->{sender}));
> my $sender = PMG::Utils::rfc1522_to_html(PVE::Tools::trim($head->get('sender')));
>
> if ($sender) {
next prev parent reply other threads:[~2022-11-15 14:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 9:28 Stoiko Ivanov
2022-11-15 14:19 ` Dominik Csapak [this message]
2022-11-15 14:32 ` [pmg-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8df49fde-d500-646e-84c1-7f4b2a330b06@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox